Sb separation language change#132
Open
sbagg wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates separation-related user-facing language to reflect that the relevant date is the employee’s “Last Day of System Access” (Issue #125), spanning UI labels, RT ticket content, operational reminders, and documentation.
Changes:
- Updated separation UI labels (new form, list, and single-record display) to “Last Day of System Access”.
- Updated RT ticket “Details” field label and the reminder email subject/body language.
- Updated maintenance job and README wording to align with the new terminology.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| services/maintenance/src/check-separation-records.js | Updates job docstring language for the reminder timing. |
| services/lib/models/admin.js | Updates log strings and RT reminder subject/body wording. |
| services/app/client/src/elements/pages/ucdlib-iam-page-separation-single.tpl.js | Updates separation record display label. |
| services/app/client/src/elements/pages/ucdlib-iam-page-separation-new.tpl.js | Updates separation form date label. |
| services/app/client/src/elements/components/ucdlib-iam-separation-list.tpl.js | Updates separation list label. |
| services/app/api/separation.js | Updates RT ticket “Details” field label. |
| readme.md | Updates separation process documentation wording. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| reply.addSubject('Reminder: Employee Separation Date'); | ||
| reply.addContent(`This is just a reminder for ITIS administrators that the separation date (${separationDay}) for ${employeeName} has passed.`); | ||
| reply.addSubject('Reminder: Employee\'s Last Day of System Access'); | ||
| reply.addContent(`This is just a reminder for ITIS administrators that the last day of system access (${separationDay}) for ${employeeName} has passed.`); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #125