TypeScriptified data generator date utils - #30039
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: QUIET Plan: Pro Plus Run ID: 📒 Files selected for processing (31)
Included review availability: Your plan includes up to 10 reviews per rolling hour; 7 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (13)
🧰 Additional context used📓 Path-based instructions (5)**/*.{js,jsx,cjs,mjs}📄 CodeRabbit inference engine (Custom checks)
Files:
⚙️ CodeRabbit configuration file
Files:
**/*📄 CodeRabbit inference engine (AGENTS.md)
Files:
⚙️ CodeRabbit configuration file
Files:
**/*.{ts,tsx}📄 CodeRabbit inference engine (Custom checks)
Files:
**/*.{ts,tsx,mts,cts}⚙️ CodeRabbit configuration file
Files:
**/*{.,-}{test,spec}.{js,jsx,ts,tsx}⚙️ CodeRabbit configuration file
Files:
🧠 Learnings (9)📚 Learning: 2026-01-08T10:26:38.700ZApplied to files:
📚 Learning: 2026-02-04T15:58:09.124ZApplied to files:
📚 Learning: 2026-04-09T09:44:26.783ZApplied to files:
📚 Learning: 2026-06-04T15:15:20.265ZApplied to files:
📚 Learning: 2026-06-22T14:36:35.803ZApplied to files:
📚 Learning: 2026-07-20T10:54:38.657ZApplied to files:
📚 Learning: 2026-07-21T16:24:24.623ZApplied to files:
📚 Learning: 2026-01-26T13:53:03.597ZApplied to files:
📚 Learning: 2026-03-12T10:43:01.366ZApplied to files:
🔇 Additional comments (31)
WalkthroughThe database-date utility now uses typed ES-module exports for Possibly related PRs
Suggested reviewers: Merge Risk: ⚪ Minimal · up to This localized TypeScript conversion is merge-ready after normal checks and review; no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run ghost:test:ci:integration |
✅ Succeeded | 3m 19s | View ↗ |
nx run ghost:test:integration |
✅ Succeeded | 2m 31s | View ↗ |
nx run ghost:test:legacy |
✅ Succeeded | 3m 12s | View ↗ |
nx run ghost:test:e2e |
✅ Succeeded | 2m 13s | View ↗ |
nx run-many -t test:unit -p ghost |
✅ Succeeded | 26s | View ↗ |
nx run ghost-monorepo:lint:boundaries |
✅ Succeeded | 21s | View ↗ |
nx run @tryghost/admin:build |
✅ Succeeded | 7s | View ↗ |
nx run-many -t lint -p ghost,ghost-monorepo |
✅ Succeeded | 19s | View ↗ |
nx run-many --target=build --projects=tag:publi... |
✅ Succeeded | 1s | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-08-17 22:39:23 UTC
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #30039 +/- ##
==========================================
- Coverage 75.32% 75.32% -0.01%
==========================================
Files 1603 1603
Lines 142363 142355 -8
Branches 17569 17566 -3
==========================================
- Hits 107241 107234 -7
- Misses 34097 34122 +25
+ Partials 1025 999 -26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no ref
I recommend reviewing this one commit at a time.