feat(dev): push containers that are built in PRs to GHCR and Dockerhub#9638
feat(dev): push containers that are built in PRs to GHCR and Dockerhub#9638perfectra1n wants to merge 1 commit into
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
@perfectra1n , if I understand correctly this PR will generate an image for every PR. Is there a clean-up mechanism? I wouldn't want to have thousands of images. |
|
Why not? It would provide a complete point-in-time snapshot of the code at that time, so it'd not only serve as a mechanism to easily review PRs, we could also easily see when a feature "broke". There's no cost to us to push the additional tags/layers, and it doesn't result in any changes to the "core" tags that's users rely on (e.g. "main", "stable", etc.) If the concern is to be a good netizen, there are several other projects that push containers for PRs (and even commits). Immich, PostHog, Mastodon, and OpenClaw are some examples of projects that push containers tags on both commits and PRs. We're already building the containers in CI/CD, we're just not pushing them to the registry. |
No description provided.