Skip to content

feat(dev): push containers that are built in PRs to GHCR and Dockerhub#9638

Open
perfectra1n wants to merge 1 commit into
mainfrom
feat/push-pr-container-tags
Open

feat(dev): push containers that are built in PRs to GHCR and Dockerhub#9638
perfectra1n wants to merge 1 commit into
mainfrom
feat/push-pr-container-tags

Conversation

@perfectra1n

Copy link
Copy Markdown
Member

No description provided.

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 3, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@eliandoran

Copy link
Copy Markdown
Contributor

@perfectra1n , if I understand correctly this PR will generate an image for every PR. Is there a clean-up mechanism? I wouldn't want to have thousands of images.

@perfectra1n

Copy link
Copy Markdown
Member Author

Why not? It would provide a complete point-in-time snapshot of the code at that time, so it'd not only serve as a mechanism to easily review PRs, we could also easily see when a feature "broke".

There's no cost to us to push the additional tags/layers, and it doesn't result in any changes to the "core" tags that's users rely on (e.g. "main", "stable", etc.)

If the concern is to be a good netizen, there are several other projects that push containers for PRs (and even commits). Immich, PostHog, Mastodon, and OpenClaw are some examples of projects that push containers tags on both commits and PRs.

We're already building the containers in CI/CD, we're just not pushing them to the registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants