Added support for custom JSON configuration in the forwarder component#667
Merged
Merged
Conversation
Member
|
Thanks for contributing @falboe! I extended the interface a bit to be consistent with how other configs work. :) |
Replace the separate Config.Unmarshal / PublisherConfig.Marshal function fields with a single forwarder.Marshaler interface and a DefaultMarshaler implementation backed by encoding/json. The interface mirrors the encoding/json API so drop-in alternatives (sonic, goccy/go-json, …) only need a thin wrapper.
a6b2b13 to
9867a04
Compare
roblaszczak
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces the ability to inject a custom JSON marshal/unmarshal implementation into the Forwarder component.
This makes the component more flexible and allows consumers to use alternative JSON libraries (e.g. Sonic) instead of being tightly coupled to the standard encoding/json package.