Add ITTNotify CI workflow and smoke test#7258
Add ITTNotify CI workflow and smoke test#7258v4xsh wants to merge 6 commits intoTheHPXProject:masterfrom
Conversation
Signed-off-by: v4xsh <vanshdobhal11@gmail.com>
Signed-off-by: v4xsh <vanshdobhal11@gmail.com>
Signed-off-by: v4xsh <vanshdobhal11@gmail.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 4 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
Can one of the admins verify this patch? |
Signed-off-by: v4xsh <vanshdobhal11@gmail.com>
a577415 to
89a286f
Compare
|
@v4xsh Thanks for creating this! In addition to the example you added (which doesn't really show any use of the ITT API, BTW), I'd like to see a test that verifies the API's use - perhaps by utilizing the ITT ref-collector from that repository (https://intel.github.io/ittapi/src/ref_collector.html)? |
Signed-off-by: v4xsh <vanshdobhal11@gmail.com>
Thanks! Updated the smoke test to use the ITT RAII wrappers directly (domain, task, string_handle, mark_context) and added the ittapi ref-collector to the CI workflow — it now builds the ref-collector, runs the test with INTEL_LIBITTNOTIFY64 set, and greps the log for __itt_domain_create / __itt_task_begin to verify the calls actually went through. Let me know if this looks good or if anything else is needed. |
a44df9b to
9131b74
Compare
Thanks! We should make the CI fail if the log doesn't contain the outputs you're looking for, though. |
Yep, the verify step already fails the CI if the expected calls aren't in the log. Waiting on this run to confirm everything looks good. |
You may need to pass the command line option |
Signed-off-by: v4xsh <vanshdobhal11@gmail.com>
9131b74 to
0844d80
Compare
Good call, that was the issue. Added HPX_HAVE_ITTNOTIFY=1 as an env var in the test step so the bindings are enabled when the ref-collector runs. |
Proposed Changes
Any background context you want to provide?
Follow-up to #7250. This uses intel/ittapi as a lightweight stand-in that provides the ittnotify headers and static library without needing a full VTune install.
Checklist