Skip to content

ScriptEngine unloading domain during shutdown. #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GrisWoldDiablo wants to merge 3 commits into
base: scripting
Choose a base branch
from
Open

ScriptEngine unloading domain during shutdown. #573

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3cf2970
ScriptEngine unloading domain during shutdown.
GrisWoldDiablo Jul 23, 2022
82bcc41
Fixed formatting
GrisWoldDiablo Jul 23, 2022
8d41750
Use already store RootDomain pointer
GrisWoldDiablo Jul 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Hazel/src/Hazel/Scripting/ScriptEngine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,12 +162,12 @@ namespace Hazel {

void ScriptEngine::ShutdownMono()
{
// NOTE(Yan): mono is a little confusing to shutdown, so maybe come back to this
mono_domain_set(s_Data->RootDomain, false);

// mono_domain_unload(s_Data->AppDomain);
mono_domain_unload(s_Data->AppDomain);
s_Data->AppDomain = nullptr;

// mono_jit_cleanup(s_Data->RootDomain);
mono_jit_cleanup(s_Data->RootDomain);
s_Data->RootDomain = nullptr;
}

Expand Down