Skip to content

docs: clarify sorted array prerequisite in binary search#14671

Closed
Jags-08 wants to merge 1 commit into
TheAlgorithms:masterfrom
Jags-08:docs/clarify-binary-search
Closed

docs: clarify sorted array prerequisite in binary search#14671
Jags-08 wants to merge 1 commit into
TheAlgorithms:masterfrom
Jags-08:docs/clarify-binary-search

Conversation

@Jags-08
Copy link
Copy Markdown

@Jags-08 Jags-08 commented May 12, 2026

Hello! This is a simple documentation addition to �inary_search.py reminding future users/students that the array must be sorted before the search is executed. Thank you for this repository!

@algorithms-keeper
Copy link
Copy Markdown

Closing this pull request as invalid

@Jags-08, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label May 12, 2026
@Jags-08
Copy link
Copy Markdown
Author

Jags-08 commented May 12, 2026

Just confirmed this builds cleanly locally. Let me know if there are any formatting guidelines I missed for the searches module.

@Jags-08
Copy link
Copy Markdown
Author

Jags-08 commented May 12, 2026

I'll leave this in your hands for review now. Happy to squash or adjust if there are module-specific guidelines I missed.

@Jags-08
Copy link
Copy Markdown
Author

Jags-08 commented May 13, 2026

Just following up to ensure the logic holds. Happy to close and tweak if there are any search array regressions triggered.

@Jags-08
Copy link
Copy Markdown
Author

Jags-08 commented May 13, 2026

Thanks again for the time and feedback on this. I'll keep an eye on upstream shifts going forward.

@Jags-08
Copy link
Copy Markdown
Author

Jags-08 commented May 13, 2026

The CI checks all look perfectly clean. Everything is squared away on my end here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed invalid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant