Use Content tooltips for Markdown table cells - #6649
Open
Devil1716 wants to merge 1 commit into
Open
Conversation
compose() passed cell.plain (str) into with_tooltip, which renders markup-enabled and raises MarkupError for bracketed cell text like ([sys:LOCK=SAFE]). Pass the Content object instead, matching the streaming _update_rows path. Fixes Textualize#6642 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Content(notcell.plainstr) to Markdown table cell tooltips incompose(), matching the streaming path so bracketed text is not parsed as markup.Test plan
ONE_SHOT = Trueno longer raisesMarkupErroron cell hoverFixes #6642