Skip to content

feat(ButtonLink): added ButtonLinkNeutral - #1672

Open
AlexandraGallipoliRodrigues wants to merge 3 commits into
masterfrom
alex/added-ButtonLinkNeutral
Open

feat(ButtonLink): added ButtonLinkNeutral#1672
AlexandraGallipoliRodrigues wants to merge 3 commits into
masterfrom
alex/added-ButtonLinkNeutral

Conversation

@AlexandraGallipoliRodrigues

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown

Size stats

master this branch diff
Total JS 15.7 MB 15.7 MB +1.17 kB
JS without icons 1.93 MB 1.93 MB +1.11 kB
Lib overhead 96.9 kB 96.9 kB -43 B
Lib overhead (gzip) 21.3 kB 21.2 kB -46 B

@github-actions

Copy link
Copy Markdown

Deploy preview for mistica-web ready!

Project:mistica-web
Status: ✅  Deploy successful!
Preview URL:https://mistica-pkp65iiul-flows-projects-65bb050e.vercel.app
Latest Commit:affa67e

Deployed with vercel-action

@github-actions

Copy link
Copy Markdown

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@AlexandraGallipoliRodrigues
AlexandraGallipoliRodrigues marked this pull request as ready for review July 28, 2026 10:56
@AlexandraGallipoliRodrigues
AlexandraGallipoliRodrigues requested a review from a team as a code owner July 28, 2026 10:56
Copilot AI review requested due to automatic review settings July 28, 2026 10:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new neutral typology for ButtonLink across the component API, styles, stories, and skins, aligning with the design-system need described in issue #1582.

Changes:

  • Introduces ButtonLinkNeutral as a first-class export and adds linkNeutral to the internal ButtonType.
  • Adds neutral link styling variants for default/brand/negative/media theme variants in button.css.ts.
  • Updates Storybook stories, screenshot coverage, playroom snippets, and multiple skins to provide the required neutral tokens.

Reviewed changes

Copilot reviewed 14 out of 97 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/skins/vivo.tsx Updates neutral link background/text tokens to new neutral spec values.
src/skins/vivo-evolution.tsx Updates neutral link background/text tokens to new neutral spec values.
src/skins/telefonica.tsx Updates neutral link background/text tokens to new neutral spec values.
src/skins/o2.tsx Updates neutral link background/text tokens to new neutral spec values.
src/skins/movistar.tsx Updates neutral link background/text tokens to new neutral spec values.
src/skins/esimflag.tsx Updates neutral link background/text tokens to new neutral spec values (both sections in file).
src/skins/blau.tsx Updates neutral link background/text tokens to new neutral spec values.
src/index.tsx Exports ButtonLinkNeutral from the public entrypoint.
src/button.tsx Adds linkNeutral type + ButtonLinkNeutral component and tracking mapping.
src/button.css.ts Adds linkNeutral style variants across default/brand/negative/media.
src/stories/button-story.tsx Adds Storybook story + controls for ButtonLinkNeutral.
src/screenshot_tests/button-screenshot-test.tsx Includes neutral link in screenshot test matrix.
src/private_stories/skin-components-story.tsx Adds ButtonLinkNeutral usage in skin components story.
playroom/snippets.tsx Adds playroom snippet for ButtonLinkNeutral.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AnaMontes11
AnaMontes11 self-requested a review July 29, 2026 06:50
@Marcosld

Copy link
Copy Markdown
Contributor

I suppose we didn't unify because it would be a breaking change? Perhaps we can do it and mark with @deprecated the ButtonLinkDanger?

@brtbrt

brtbrt commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

I suppose we didn't unify because it would be a breaking change? Perhaps we can do it and mark with @deprecated the ButtonLinkDanger?

that should have been specified in the issue description, actually. if you wanna deprecate things, please add the removal into the next major release #1645

@AnaMontes11

AnaMontes11 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

I suppose we didn't unify because it would be a breaking change? Perhaps we can do it and mark with @deprecated the ButtonLinkDanger?

For some context, @Marcosld @brtbrt : from the Design side, we think the button ecosystem needs a proper review. However, this isn't the right time to tackle it, and we don't want to block the PR because of it.

What we're proposing is to take advantage of the introduction of the neutral style and add it as a new type (ideally, danger should follow the same approach). The goal is to converge towards an API like type: default | neutral | danger, aligned with IconButton.

We believe this is the right time to introduce it this way, rather than creating a separate component that we'd end up deprecating later.

From our perspective, we're happy to mark ButtonLinkDanger as deprecated and introduce both danger and neutral as new type values.

Even the ButtonLink naming itself is something that could be revisited in the future.

If you want we can have a quick call to discuss it.

@Marcosld

Marcosld commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

I suppose we didn't unify because it would be a breaking change? Perhaps we can do it and mark with @deprecated the ButtonLinkDanger?

that should have been specified in the issue description, actually. if you wanna deprecate things, please add the removal into the next major release #1645

Well, it is specified in the issue:

Additionally, it is proposed to unify the component under a single type, which would include: ButtonLinkBrand (current default variant), ButtonLinkNeutral (new variant) and ButtonLinkDanger (currently independent variant).

I'm up to making the change you propose @AnaMontes11 ! That's why I flagged it just in case we forgot

@AnaMontes11

Copy link
Copy Markdown
Contributor

Supongo que no nos unificamos porque sería un cambio radical. Tal vez podamos hacerlo y marcarlo con@deprecated¿El enlace del botón es peligroso?

Eso debería haberse especificado en la descripción del problema. Si quieres descontinuar funciones, por favor, agrega la eliminación en la próxima versión principal #1645.

Bueno, está especificado en el problema:

Además, se propone unificar el componente bajo un único tipo, que incluiría: ButtonLinkBrand (variante predeterminada actual), ButtonLinkNeutral (nueva variante) y ButtonLinkDanger (variante actualmente independiente).

Estoy dispuesto a hacer el cambio que propones.@AnaMontes11¡Por eso lo marqué, por si acaso lo olvidábamos!

Great @Marcosld thanks for adding it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Mística] new neutral button link

6 participants