feat(ButtonLink): added ButtonLinkNeutral - #1672
feat(ButtonLink): added ButtonLinkNeutral#1672AlexandraGallipoliRodrigues wants to merge 3 commits into
Conversation
|
Size stats
|
|
Deploy preview for mistica-web ready!
Deployed with vercel-action |
|
Accessibility report ℹ️ You can run this locally by executing |
There was a problem hiding this comment.
Pull request overview
Adds a new neutral typology for ButtonLink across the component API, styles, stories, and skins, aligning with the design-system need described in issue #1582.
Changes:
- Introduces
ButtonLinkNeutralas a first-class export and addslinkNeutralto the internalButtonType. - Adds neutral link styling variants for default/brand/negative/media theme variants in
button.css.ts. - Updates Storybook stories, screenshot coverage, playroom snippets, and multiple skins to provide the required neutral tokens.
Reviewed changes
Copilot reviewed 14 out of 97 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/skins/vivo.tsx | Updates neutral link background/text tokens to new neutral spec values. |
| src/skins/vivo-evolution.tsx | Updates neutral link background/text tokens to new neutral spec values. |
| src/skins/telefonica.tsx | Updates neutral link background/text tokens to new neutral spec values. |
| src/skins/o2.tsx | Updates neutral link background/text tokens to new neutral spec values. |
| src/skins/movistar.tsx | Updates neutral link background/text tokens to new neutral spec values. |
| src/skins/esimflag.tsx | Updates neutral link background/text tokens to new neutral spec values (both sections in file). |
| src/skins/blau.tsx | Updates neutral link background/text tokens to new neutral spec values. |
| src/index.tsx | Exports ButtonLinkNeutral from the public entrypoint. |
| src/button.tsx | Adds linkNeutral type + ButtonLinkNeutral component and tracking mapping. |
| src/button.css.ts | Adds linkNeutral style variants across default/brand/negative/media. |
| src/stories/button-story.tsx | Adds Storybook story + controls for ButtonLinkNeutral. |
| src/screenshot_tests/button-screenshot-test.tsx | Includes neutral link in screenshot test matrix. |
| src/private_stories/skin-components-story.tsx | Adds ButtonLinkNeutral usage in skin components story. |
| playroom/snippets.tsx | Adds playroom snippet for ButtonLinkNeutral. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I suppose we didn't unify because it would be a breaking change? Perhaps we can do it and mark with @deprecated the ButtonLinkDanger? |
that should have been specified in the issue description, actually. if you wanna deprecate things, please add the removal into the next major release #1645 |
For some context, @Marcosld @brtbrt : from the Design side, we think the button ecosystem needs a proper review. However, this isn't the right time to tackle it, and we don't want to block the PR because of it. What we're proposing is to take advantage of the introduction of the neutral style and add it as a new We believe this is the right time to introduce it this way, rather than creating a separate component that we'd end up deprecating later. From our perspective, we're happy to mark Even the If you want we can have a quick call to discuss it. |
Well, it is specified in the issue:
I'm up to making the change you propose @AnaMontes11 ! That's why I flagged it just in case we forgot |
Great @Marcosld thanks for adding it! |
issue