core: fix ineffective biome-ignore on ResolverRegistry (unblock lint gate) - #87
Conversation
…gate) The `noExplicitAny` suppression for `ResolverRegistry` was written across two comment lines; the continuation line sits between the `// biome-ignore` directive and the annotated `export type`, so Biome reports the suppression as unused — one error, which fails the `pnpm lint:biome` CI gate (it is clean of prior backlog, so any error is fatal). Collapse it to a single-line biome-ignore, the same form the adjacent `AnyResolveContext` suppression already uses. No behaviour change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request reformats the Biome lint-ignore directive above ChangesLint Directive Formatting
Estimated code review effort: 1 (Trivial) | ~2 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
The
noExplicitAnysuppression forResolverRegistryinSpatialEntryStore.tsis written across two comment lines. Because the continuation line sits between the// biome-ignoredirective and the annotatedexport type, Biome reports the suppression as unused — onesuppressions/unusederror.That single error fails the
biome-lintCI job (pnpm lint:biome→biome ci packages/*/src), which is intentionally clean of prior backlog and therefore treats any error as fatal. The gate is currently red onmainbecause of it.Fix
Collapse the suppression to a single-line
// biome-ignore, matching the form the adjacentAnyResolveContextsuppression already uses. No behaviour change.Verification
pnpm lint:biome(biome ci packages/*/src) now exits0(0 errors, warnings unchanged).🤖 Generated with Claude Code
Summary by CodeRabbit