Skip to content

core: fix ineffective biome-ignore on ResolverRegistry (unblock lint gate) - #87

Merged
xinaesthete merged 1 commit into
mainfrom
claude/fix-biome-suppression-spatialentrystore
Jul 17, 2026
Merged

core: fix ineffective biome-ignore on ResolverRegistry (unblock lint gate)#87
xinaesthete merged 1 commit into
mainfrom
claude/fix-biome-suppression-spatialentrystore

Conversation

@xinaesthete

@xinaesthete xinaesthete commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

What

The noExplicitAny suppression for ResolverRegistry in SpatialEntryStore.ts is written across two comment lines. Because the continuation line sits between the // biome-ignore directive and the annotated export type, Biome reports the suppression as unused — one suppressions/unused error.

That single error fails the biome-lint CI job (pnpm lint:biomebiome ci packages/*/src), which is intentionally clean of prior backlog and therefore treats any error as fatal. The gate is currently red on main because of it.

Fix

Collapse the suppression to a single-line // biome-ignore, matching the form the adjacent AnyResolveContext suppression already uses. No behaviour change.

Verification

pnpm lint:biome (biome ci packages/*/src) now exits 0 (0 errors, warnings unchanged).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Simplified an internal lint directive without affecting application behavior or public functionality.

…gate)

The `noExplicitAny` suppression for `ResolverRegistry` was written across two
comment lines; the continuation line sits between the `// biome-ignore` directive
and the annotated `export type`, so Biome reports the suppression as unused —
one error, which fails the `pnpm lint:biome` CI gate (it is clean of prior
backlog, so any error is fatal). Collapse it to a single-line biome-ignore, the
same form the adjacent `AnyResolveContext` suppression already uses. No behaviour
change.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1f15829f-db22-4bf1-b990-b91cf9f49955

📥 Commits

Reviewing files that changed from the base of the PR and between 716bc44 and e3c097f.

📒 Files selected for processing (1)
  • packages/core/src/engine/SpatialEntryStore.ts

📝 Walkthrough

Walkthrough

The pull request reformats the Biome lint-ignore directive above ResolverRegistry from multiple lines into a single-line comment without changing runtime or type behavior.

Changes

Lint Directive Formatting

Layer / File(s) Summary
Reformat lint-ignore directive
packages/core/src/engine/SpatialEntryStore.ts
The wrapped Biome suppression comment above ResolverRegistry is consolidated into one line.

Estimated code review effort: 1 (Trivial) | ~2 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/fix-biome-suppression-spatialentrystore

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@xinaesthete
xinaesthete merged commit 5e29c2e into main Jul 17, 2026
3 of 4 checks passed
@xinaesthete
xinaesthete deleted the claude/fix-biome-suppression-spatialentrystore branch July 17, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant