Skip to content

feat(QTDI-2134): fix pr comments

32d0fd0
Select commit
Loading
Failed to load commit list.
Open

feat(QTDI-2134): dynamic dependencies #1143

feat(QTDI-2134): fix pr comments
32d0fd0
Select commit
Loading
Failed to load commit list.
sonar-rnd / SonarQube Code Analysis failed May 15, 2026 in 1m 25s

Quality Gate failed

Failed Quality Gate failed

  • 0.00% Coverage on New Code (is less than 80.00%)
  • 0.00% Security Hotspots Reviewed on New Code (is less than 100.00%)
  • 83 New Issues (is greater than 0)

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube

Annotations

Check warning on line 100 in component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/service/ResolverImpl.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/service/ResolverImpl.java#L100

Replace this usage of "ConfigurableClassLoader.class.isInstance()" with "instanceof ConfigurableClassLoader".

Check failure on line 916 in component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/ComponentManager.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/ComponentManager.java#L916

Refactor this method to reduce its Cognitive Complexity from 31 to the 15 allowed.

Check failure on line 1723 in component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/ComponentManager.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/ComponentManager.java#L1723

Refactor this method to reduce its Cognitive Complexity from 30 to the 15 allowed.

Check warning on line 178 in component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/ResolverImplTest.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/ResolverImplTest.java#L178

Use assertSame instead.

Check notice on line 203 in component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/ResolverImplTest.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/ResolverImplTest.java#L203

Complete the task associated to this TODO comment.

Check failure on line 42 in sample-parent/sample-features/loading-analysis/loading-dependencies-with-dataset/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/withdataset/input/DynamicDependenciesWithDatasetInput.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

sample-parent/sample-features/loading-analysis/loading-dependencies-with-dataset/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/withdataset/input/DynamicDependenciesWithDatasetInput.java#L42

Make "recordIterator" transient or serializable.

Check notice on line 36 in sample-parent/sample-features/loading-analysis/loading-dependencies-with-dataset/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/withdataset/service/DynamicDependenciesWithDatasetService.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

sample-parent/sample-features/loading-analysis/loading-dependencies-with-dataset/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/withdataset/service/DynamicDependenciesWithDatasetService.java#L36

Reorder the modifiers to comply with the Java Language Specification.

Check notice on line 34 in sample-parent/sample-features/loading-analysis/loading-dependencies-with-dataset/src/test/java/org/talend/sdk/component/sample/feature/loadinganalysis/withdataset/service/DynamicDependenciesWithDatasetServiceTest.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

sample-parent/sample-features/loading-analysis/loading-dependencies-with-dataset/src/test/java/org/talend/sdk/component/sample/feature/loadinganalysis/withdataset/service/DynamicDependenciesWithDatasetServiceTest.java#L34

Remove this 'public' modifier.

Check failure on line 42 in sample-parent/sample-features/loading-analysis/loading-dependencies-with-datastore/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/withdatastore/input/DynamicDependenciesWithDatastoreInput.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

sample-parent/sample-features/loading-analysis/loading-dependencies-with-datastore/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/withdatastore/input/DynamicDependenciesWithDatastoreInput.java#L42

Make "recordIterator" transient or serializable.

Check notice on line 37 in sample-parent/sample-features/loading-analysis/loading-dependencies-with-datastore/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/withdatastore/service/DynamicDependenciesWithDatastoreService.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

sample-parent/sample-features/loading-analysis/loading-dependencies-with-datastore/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/withdatastore/service/DynamicDependenciesWithDatastoreService.java#L37

Reorder the modifiers to comply with the Java Language Specification.

Check warning on line 39 in sample-parent/sample-features/loading-analysis/loading-services-and-resources-lib/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/classloadertestlibrary/spiConsumers/AbstractSPIConsumer.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

sample-parent/sample-features/loading-analysis/loading-services-and-resources-lib/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/classloadertestlibrary/spiConsumers/AbstractSPIConsumer.java#L39

Catch Exception instead of Throwable.

Check notice on line 16 in sample-parent/sample-features/loading-analysis/loading-services-and-resources-lib/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/classloadertestlibrary/spiConsumers/AbstractSPIConsumer.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

sample-parent/sample-features/loading-analysis/loading-services-and-resources-lib/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/classloadertestlibrary/spiConsumers/AbstractSPIConsumer.java#L16

Rename this package name to match the regular expression '^[a-z_]+(\.[a-z_][a-z0-9_]*)*$'.

Check notice on line 43 in sample-parent/sample-features/loading-analysis/loading-services-and-resources-lib/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/classloadertestlibrary/spiConsumers/AbstractSPIConsumer.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

sample-parent/sample-features/loading-analysis/loading-services-and-resources-lib/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/classloadertestlibrary/spiConsumers/AbstractSPIConsumer.java#L43

Use isEmpty() to check whether the collection is empty or not.

Check warning on line 28 in sample-parent/sample-features/loading-analysis/loading-services-and-resources-lib/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/classloadertestlibrary/spiConsumers/DynamicDependencySPIConsumer.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

sample-parent/sample-features/loading-analysis/loading-services-and-resources-lib/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/classloadertestlibrary/spiConsumers/DynamicDependencySPIConsumer.java#L28

Call "Optional#isPresent()" or "!Optional#isEmpty()" before accessing the value.

Check notice on line 16 in sample-parent/sample-features/loading-analysis/loading-services-and-resources-lib/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/classloadertestlibrary/spiConsumers/DynamicDependencySPIConsumer.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

sample-parent/sample-features/loading-analysis/loading-services-and-resources-lib/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/classloadertestlibrary/spiConsumers/DynamicDependencySPIConsumer.java#L16

Rename this package name to match the regular expression '^[a-z_]+(\.[a-z_][a-z0-9_]*)*$'.

Check warning on line 28 in sample-parent/sample-features/loading-analysis/loading-services-and-resources-lib/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/classloadertestlibrary/spiConsumers/DependencySPIConsumer.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

sample-parent/sample-features/loading-analysis/loading-services-and-resources-lib/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/classloadertestlibrary/spiConsumers/DependencySPIConsumer.java#L28

Call "Optional#isPresent()" or "!Optional#isEmpty()" before accessing the value.

Check notice on line 16 in sample-parent/sample-features/loading-analysis/loading-services-and-resources-lib/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/classloadertestlibrary/spiConsumers/DependencySPIConsumer.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

sample-parent/sample-features/loading-analysis/loading-services-and-resources-lib/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/classloadertestlibrary/spiConsumers/DependencySPIConsumer.java#L16

Rename this package name to match the regular expression '^[a-z_]+(\.[a-z_][a-z0-9_]*)*$'.

Check warning on line 28 in sample-parent/sample-features/loading-analysis/loading-services-and-resources-lib/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/classloadertestlibrary/spiConsumers/ExternalDependencySPIConsumer.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

sample-parent/sample-features/loading-analysis/loading-services-and-resources-lib/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/classloadertestlibrary/spiConsumers/ExternalDependencySPIConsumer.java#L28

Call "Optional#isPresent()" or "!Optional#isEmpty()" before accessing the value.

Check notice on line 16 in sample-parent/sample-features/loading-analysis/loading-services-and-resources-lib/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/classloadertestlibrary/spiConsumers/ExternalDependencySPIConsumer.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

sample-parent/sample-features/loading-analysis/loading-services-and-resources-lib/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/classloadertestlibrary/spiConsumers/ExternalDependencySPIConsumer.java#L16

Rename this package name to match the regular expression '^[a-z_]+(\.[a-z_][a-z0-9_]*)*$'.

Check notice on line 16 in sample-parent/sample-features/loading-analysis/loading-services-and-resources-lib/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/classloadertestlibrary/serviceInterfaces/StringProviderSPIAsDependency.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

sample-parent/sample-features/loading-analysis/loading-services-and-resources-lib/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/classloadertestlibrary/serviceInterfaces/StringProviderSPIAsDependency.java#L16

Rename this package name to match the regular expression '^[a-z_]+(\.[a-z_][a-z0-9_]*)*$'.

Check notice on line 16 in sample-parent/sample-features/loading-analysis/loading-services-and-resources-lib/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/classloadertestlibrary/serviceInterfaces/StringProviderFromExternalSPI.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

sample-parent/sample-features/loading-analysis/loading-services-and-resources-lib/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/classloadertestlibrary/serviceInterfaces/StringProviderFromExternalSPI.java#L16

Rename this package name to match the regular expression '^[a-z_]+(\.[a-z_][a-z0-9_]*)*$'.

Check notice on line 16 in sample-parent/sample-features/loading-analysis/loading-services-and-resources-lib/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/classloadertestlibrary/serviceInterfaces/StringProviderSPIAsDynamicDependency.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

sample-parent/sample-features/loading-analysis/loading-services-and-resources-lib/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/classloadertestlibrary/serviceInterfaces/StringProviderSPIAsDynamicDependency.java#L16

Rename this package name to match the regular expression '^[a-z_]+(\.[a-z_][a-z0-9_]*)*$'.

Check failure on line 42 in sample-parent/sample-features/loading-analysis/loading-services-and-resources/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/withspi/input/DynamicDependenciesWithSPIInput.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

sample-parent/sample-features/loading-analysis/loading-services-and-resources/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/withspi/input/DynamicDependenciesWithSPIInput.java#L42

Make "recordIterator" transient or serializable.

Check failure on line 92 in sample-parent/sample-features/loading-analysis/loading-services-and-resources/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/withspi/service/DynamicDependenciesWithSPIService.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

sample-parent/sample-features/loading-analysis/loading-services-and-resources/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/withspi/service/DynamicDependenciesWithSPIService.java#L92

Define a constant instead of duplicating this literal "comment" 5 times.

Check failure on line 66 in sample-parent/sample-features/loading-analysis/loading-services-and-resources/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/withspi/service/DynamicDependenciesWithSPIService.java

See this annotation in the file changed.

@sonar-rnd sonar-rnd / SonarQube Code Analysis

sample-parent/sample-features/loading-analysis/loading-services-and-resources/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/withspi/service/DynamicDependenciesWithSPIService.java#L66

Make "jsonBuilderFactory" transient or serializable.