Skip to content

chore: replace serdeconv with toml and serde_json - #4435

Merged
wsxiaoys merged 2 commits into
nextfrom
chore/toml-json-crates
Feb 9, 2026
Merged

chore: replace serdeconv with toml and serde_json#4435
wsxiaoys merged 2 commits into
nextfrom
chore/toml-json-crates

Conversation

@zwpaper

@zwpaper zwpaper commented Feb 5, 2026

Copy link
Copy Markdown
Member

Summary

This change replaces serdeconv with toml and serde_json crates directly.
This is to add support for multiple lines table in toml for our config.

Test plan

Manually verified by Wei:

  • llama read model.json
  • event service to json in log
  • read config
  • language from toml
  • model registry to/from json

🤖 Generated with Pochi | Task

@zwpaper
zwpaper requested a review from wsxiaoys February 5, 2026 14:22
@codecov

codecov Bot commented Feb 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 23.52941% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.46%. Comparing base (e19008a) to head (311a1b9).
⚠️ Report is 3 commits behind head on next.

Files with missing lines Patch % Lines
crates/tabby-common/src/config.rs 28.57% 5 Missing ⚠️
crates/tabby-common/src/registry.rs 33.33% 4 Missing ⚠️
crates/llama-cpp-server/src/lib.rs 0.00% 3 Missing ⚠️
crates/tabby/src/services/event.rs 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (23.52%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4435      +/-   ##
==========================================
+ Coverage   54.35%   54.46%   +0.11%     
==========================================
  Files         227      227              
  Lines       27121    26935     -186     
==========================================
- Hits        14741    14671      -70     
+ Misses      12380    12264     -116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zwpaper
zwpaper changed the base branch from main to next February 9, 2026 04:22
@wsxiaoys
wsxiaoys merged commit fc62162 into next Feb 9, 2026
6 of 8 checks passed
@wsxiaoys
wsxiaoys deleted the chore/toml-json-crates branch February 9, 2026 04:50
gunakarchalla pushed a commit to gunakarchalla/tabby that referenced this pull request May 19, 2026
* chore: replace serdeconv with toml and serde_json

🤖 Generated with [Pochi](https://getpochi.com) | [Task](https://app.getpochi.com/share/p-f3ba1b1e251548d895ac6210cf81f410)

Co-Authored-By: Pochi <noreply@getpochi.com>

* [autofix.ci] apply automated fixes

---------

Co-authored-by: Pochi <noreply@getpochi.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants