Skip to content

feat(embedding): add env to toggle embedding feature - #4429

Merged
wsxiaoys merged 3 commits into
mainfrom
feat/sunset-embedding
Jan 27, 2026
Merged

feat(embedding): add env to toggle embedding feature#4429
wsxiaoys merged 3 commits into
mainfrom
feat/sunset-embedding

Conversation

@zwpaper

@zwpaper zwpaper commented Jan 25, 2026

Copy link
Copy Markdown
Member

indexing job disabled:

image

will not search code and doc:

image

health check:
image


Enabled with env:
image

image image

@codecov

codecov Bot commented Jan 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 24.65753% with 110 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.35%. Comparing base (1881e9c) to head (78a7313).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../tabby-webserver/src/service/background_job/mod.rs 0.00% 39 Missing ⚠️
crates/tabby/src/serve.rs 0.00% 20 Missing ⚠️
ee/tabby-webserver/src/service/retrieval.rs 69.69% 10 Missing ⚠️
ee/tabby-schema/src/schema/mod.rs 0.00% 7 Missing ⚠️
ee/tabby-webserver/src/webserver.rs 0.00% 7 Missing ⚠️
crates/llama-cpp-server/src/lib.rs 0.00% 6 Missing ⚠️
crates/tabby-common/src/config.rs 0.00% 6 Missing ⚠️
ee/tabby-webserver/src/service/mod.rs 0.00% 6 Missing ⚠️
ee/tabby-webserver/src/service/repository/git.rs 0.00% 3 Missing ⚠️
...by-webserver/src/service/repository/third_party.rs 0.00% 3 Missing ⚠️
... and 3 more

❌ Your patch status has failed because the patch coverage (24.65%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4429      +/-   ##
==========================================
- Coverage   54.43%   54.35%   -0.09%     
==========================================
  Files         227      227              
  Lines       27066    27121      +55     
==========================================
+ Hits        14734    14741       +7     
- Misses      12332    12380      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zwpaper
zwpaper force-pushed the feat/sunset-embedding branch from 571b94a to 15de2f3 Compare January 26, 2026 11:22
@zwpaper
zwpaper marked this pull request as ready for review January 26, 2026 11:35
@zwpaper zwpaper changed the title feat(embedding): sunset embedding feat(embedding): add env to toggle embedding feature Jan 26, 2026
@zwpaper
zwpaper requested a review from wsxiaoys January 26, 2026 11:38
@wsxiaoys
wsxiaoys merged commit 11a72e7 into main Jan 27, 2026
5 of 8 checks passed
@wsxiaoys
wsxiaoys deleted the feat/sunset-embedding branch January 27, 2026 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants