make savestates for markers optional, per marker#4774
Open
SuuperW wants to merge 3 commits into
Open
Conversation
ce8b45e to
34abdc9
Compare
Contributor
|
I think it's better to indicate explicitly which markers have states disabled, for example with a cross. Then ones wanting a state could be empty and ones with it could have the checkmark. |
Contributor
Author
|
Crosses are sometimes used to "check" things, so I'm not sure that's better. I feel like if a user clicks a box and it toggle between a cross and blank, the cross state would feel more like the enabled state. Though I don't think I've seen crosses used like that anywhere recently, maybe it is rare enough today. Maybe instead the |
Contributor
|
I meant a red cross. That never means anything good :D
|
34abdc9 to
af16dfd
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

A new column has been added to the marker list, which controls if TAStudio will keep a savestate for each specific marker. By default all markers will have states, but this can be changed with a new settings. Clicking on the savestate cell for a particular marker will toggle if it keeps a state.
For markers not keeping a state, the cell will be blank. For markers wanting a state but not having one, the cell will have
!. For markers wanting a state and actually having a state, the cell will have✔.There might be a better way to design the user interface. Suggestions welcome.
Check if completed: