Skip to content

Add non-steam-playtimes at v1.0.0 - #49

Merged
shdwmtr merged 8 commits into
SteamClientHomebrew:mainfrom
k0d13:patch-1
Jun 12, 2025
Merged

Add non-steam-playtimes at v1.0.0#49
shdwmtr merged 8 commits into
SteamClientHomebrew:mainfrom
k0d13:patch-1

Conversation

@k0d13

@k0d13 k0d13 commented Jun 12, 2025

Copy link
Copy Markdown
Contributor

non-steam-playtimes

A Millennium plugin that tracks playtime for non-Steam games.

  • Automatically tracks how long non-Steam apps are played
  • Playtime is visible inside your Steam client alongside your official games
  • Session data is stored locally and updates as you play

Task Checklist

Developer

  • I am the original author or an authorized maintainer of this plugin.
  • I have complied with all license requirements for the libraries used, including providing appropriate notices where necessary.
  • My plugin is entirely FOSS and doesn't rely on any external paid services provided (unless incredibly well known and trusted, and you or anyone you know doesn't profit on it).

Plugin Functionality

  • I have tested the plugin on both the Stable and Beta SteamOS update channels.
  • My plugin is unique, or provides additional or alternative functionality to plugins already on the store.

Backend Configuration

  • Yes: I use a standard Millennium python backend in my plugin.
  • No: I use custom binaries that or rely on other FOSS projects that aren't written directly using Millennium's python backend.

Community Contribution

  • I have tested and left feedback on two other plugin pull requests.
  • I have added links to those feedback comments in this PR.

Testing Instructions

  • Verified by a third party on Steam Client Stable.
  • Verified by a third party on Steam Client Beta.

@shdwmtr
shdwmtr requested a review from madmaxgrey June 12, 2025 16:55
@shdwmtr

shdwmtr commented Jun 12, 2025

Copy link
Copy Markdown
Member

Millennium.callServerMethod is deprecated, and should be replaced with callable.

Other than that, the code seems fine. I'll just need a third party to test your plugin and leave a review here.

I can likely assign @madmaxgrey and he'll more than likely leave a review when he's available. We can wait for his response

@shdwmtr shdwmtr added waiting-for-testing The plugin is waiting for an external reviewer to test approved Plugin has been approved labels Jun 12, 2025
@madmaxgrey

Copy link
Copy Markdown

currently reviewing the plugin i'll get back to you in a bit with the review

@madmaxgrey madmaxgrey left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Report

  • Verified by a third party on Steam Client Stable. Yes
  • Verified by a third party on Steam Client Beta. Yes

@shdwmtr
shdwmtr merged commit a9acf4b into SteamClientHomebrew:main Jun 12, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Plugin has been approved waiting-for-testing The plugin is waiting for an external reviewer to test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants