feat: add SteamRT3 client incompatibility warning check#842
Open
hotline1337 wants to merge 3 commits into
Open
feat: add SteamRT3 client incompatibility warning check#842hotline1337 wants to merge 3 commits into
hotline1337 wants to merge 3 commits into
Conversation
Detect when the experimental SteamRT3 beta client is active and warn the user that Millennium does not support it. Implemented across PKGBUILD's post-install, install.sh (other distributions), and the Nix module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect unsupported SteamRT3 client and warn at install time
Closes #840
What this does
Adds a
check_steamrt3_incompatibilityfunction that runs after installing to warn the user when Steam is using the SteamRT3 (64-bit) experimental client, since the current preload hook targets the 32-bit client process (ubuntu12_32/libXtst.so.6) which RT3 never launches.As described in the linked issue, without this check the install completes silently and the user has no way to tell "broken install" from "unsupported client".
Detection logic
Detection is done via three on-disk markers that together indicate an active RT3 session:
$STEAM/package/beta- beta channel is active$STEAM/.steam-enable-steamrt64-client- RT3 experimental toggle is on$STEAM/steamrt64/steam- the 64-bit client binary is presentAll three must exist for the warning to fire, which avoids false positives on a stable/32-bit install.
Where it's wired in
.install(AUR/pacman hook) -post_install()calls the check.install.sh(Other distributions) - same check ported to the shell installer.extraProfilealongside the existing symlink logic, so it runs in the same shell context where$HOMEis already correctly resolved for the logged-in user.Install still proceeds either way - this is a warning, not a hard block, per the discussion in the issue.
Sample output
Testing
Tested on Arch with Steam
publicbeta+ RT3 experimental enabled (the environment from the original issue) - warning fires correctly post-install.