Skip to content

fedramp(image): apt-get upgrade in dependencies stage #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geekshiv-spotdraft wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fedramp(image): apt-get upgrade in dependencies stage #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ MAINTAINER david@logicalspark.com

FROM base as dependencies

RUN DEBIAN_FRONTEND=noninteractive apt-get -y install openjdk-17-jre-headless gdal-bin tesseract-ocr \
RUN DEBIAN_FRONTEND=noninteractive apt-get -y upgrade && DEBIAN_FRONTEND=noninteractive apt-get -y install openjdk-17-jre-headless gdal-bin tesseract-ocr \
tesseract-ocr-eng tesseract-ocr-ita tesseract-ocr-fra tesseract-ocr-spa tesseract-ocr-deu curl
Comment on lines +11 to 12

@baz-reviewer baz-reviewer Bot Jun 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependencies runs apt-get upgrade/install without refreshing package lists, so cached base layers can leave stale metadata here — should we add apt-get update to this RUN first?

Severity web_search

Want Baz to fix this for you? Activate Fixer

Fix in Cursor

Prompt for AI Agents 
Before applying, verify this suggestion against the current code. In Dockerfile around
lines 11-12 in the `dependencies` stage, the `RUN DEBIAN_FRONTEND=noninteractive apt-get
-y upgrade && ... apt-get -y install ...` runs without an `apt-get update`, relying on
cached apt lists from the `base` stage. Fix this by adding `apt-get update` in the same
RUN command (or otherwise refreshing `/var/lib/apt/lists`) before `upgrade` and
`install`, and keep it in a single layer to avoid stale metadata. Also consider cleaning
apt lists afterward (e.g., removing `/var/lib/apt/lists/*`) to prevent bloating the
image.


RUN echo ttf-mscorefonts-installer msttcorefonts/accepted-mscorefonts-eula select true | debconf-set-selections \
Expand Down