Skip to content

chore: hide ADCS ESC14 edges#340

Merged
jeff-matthews merged 1 commit into
release/v9.4.0from
hide-adcsesc14-edges
Jul 6, 2026
Merged

chore: hide ADCS ESC14 edges#340
jeff-matthews merged 1 commit into
release/v9.4.0from
hide-adcsesc14-edges

Conversation

@jeff-matthews

@jeff-matthews jeff-matthews commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Purpose

This pull request (PR) hides the ADCS ESC14 scenario A edges introduced in v9.4.0 (#325 - BED-6155) and removes related snippets from existing edges.

We're doing this because these edges require a SharpHound upgrade, but a SharpHound release is not scheduled to coincide with the v9.4.0 BloodHound release.

Note

We should revert this commit in the future when the appropriate SharpHound version is available. We removed the v9.4.0 release notes copy in a separate commit, which we can also use later.

@jeff-matthews jeff-matthews self-assigned this Jul 6, 2026
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 194bbee8-91dd-4e41-9659-bcd5e4a43ec5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hide-adcsesc14-edges

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JonasBK JonasBK left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jeff-matthews jeff-matthews merged commit 6746d8a into release/v9.4.0 Jul 6, 2026
2 checks passed
@jeff-matthews jeff-matthews deleted the hide-adcsesc14-edges branch July 6, 2026 13:54
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants