fix(models): hide unsupported API models#887
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 919f5ee951
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Soju06
added
🤖 codex: needs work
|
@codex review |
Komzpa
force-pushed
the
fix/model-visibility-supported-in-api
branch
from
a231d87 to
ecf52d6
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Soju06
added
🤖 codex: ok
Komzpa
force-pushed
the
fix/model-visibility-supported-in-api
branch
from
ecf52d6 to
9fddbb0
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9fddbb0621
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Soju06
added
🤖 codex: needs work
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Soju06
added
🤖 codex: ok
## Summary
- Wire the existing per-account probe backend endpoint (`POST /api/accounts/{accountId}/probe`) into the Accounts dashboard.
- Add the frontend schema/client method, mutation, and MSW handler coverage for force-probe.
- Add a Force probe button to the account detail action surface while preserving the newer routing policy, Trusted Access, limit warm-up, and upstream proxy controls from current `main`.
- Refresh account list, account trends, per-account trend detail, and dashboard queries after a successful force-probe.
- Keep Force probe disabled for paused, deactivated, and re-auth-required accounts that the backend rejects.
## Stack relationship
- Remains separate from #892 because this is a dashboard/account-control feature, while #892 is the Responses HTTP bridge admission/stream contract bundle.
- Remains separate from #887 because this does not touch model catalog visibility or public model metadata.
- Does not absorb or supersede another open PR.
Closes #677
## Validation
- `uv run openspec validate add-account-probe-endpoint --strict`
- `cd frontend && bun run test src/features/accounts/components/account-actions.test.tsx src/features/accounts/components/account-detail.test.tsx src/features/accounts/hooks/use-accounts.test.ts src/features/accounts/schemas.test.ts src/test/mocks/handler-coverage.test.ts`
- `cd frontend && bun run test src/features/accounts/components/accounts-page.test.tsx`
- `cd frontend && bun run test:coverage`
- `cd frontend && bun run typecheck`
- `cd frontend && bun run lint`
Current head: `6aec65730b15f4a934db0daf6c3ed5e14a4d8fb4`
GitHub CI: pending on current head after the test-fixture fix push.
Komzpa
force-pushed
the
fix/model-visibility-supported-in-api
branch
from
ff55b5b to
174d5bb
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 174d5bb9da
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Soju06
added
🤖 codex: needs work
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Soju06
added
🤖 codex: ok
Komzpa
force-pushed
the
fix/model-visibility-supported-in-api
branch
from
599d873 to
3b534e4
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Soju06
added
🤖 codex: ok
Komzpa
force-pushed
the
fix/model-visibility-supported-in-api
branch
from
3b534e4 to
52eb83c
Compare
|
@codex review |
1 similar comment
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
This pull request has been automatically marked as stale because it has had no activity for 7 days. It will be closed in 23 more days unless there is new activity. If this is still relevant, please:
Thanks for the contribution 🙏 |
github-actions
Bot
added
the
stale
3 participants
Summary
Unifies the model catalog compatibility fixes into one PR:
supported_in_api=falsefrom/api/models,/v1/models, and/backend-api/codex/modelsobject: "list"anddatafields to/backend-api/codex/models/v1/modelswhen upstream provides itThis absorbs #889 and #880. The #880 commits keep @KakatkarAkshay's authorship and contributor credit.
Fixes #876.
Fixes #608.
Fixes #834.
Folded PRs
ff55b5b5cd0765eceabdd604428a44c9fabb833fOpenSpec
api-keyspublic model filtering requirementopenspec/changes/add-codex-models-data-alias/openspec/changes/expose-v1-model-speed-tiers/Changes
is_public_model(...)./backend-api/codex/modelsin a shape compatible with clients expecting OpenAI-style list/data fields.additional_speed_tiers,service_tiers, anddefault_service_tieron/v1/modelsentries only when those fields are present upstream.Validation
uv run pytest tests/unit/test_model_registry.py tests/integration/test_v1_models.py tests/integration/test_api_keys_api.py -k 'model or public_model or supported_in_api or backend_codex_models or speed_tier or allowed_but_unsupported' -q uv run ruff check app/core/openai/model_registry.py app/modules/proxy/api.py app/modules/proxy/schemas.py tests/unit/test_model_registry.py tests/integration/test_v1_models.py tests/integration/test_api_keys_api.py uv run ty check app/core/openai/model_registry.py app/modules/proxy/api.py app/modules/proxy/schemas.py uv run openspec validate add-codex-models-data-alias --strict uv run openspec validate expose-v1-model-speed-tiers --strict uv run openspec validate --specs model-catalog-compat uv run pytest tests/integration/test_path_rewrite_alias.py tests/integration/test_v1_models.py::test_backend_codex_models_returns_format1 tests/integration/test_v1_models.py::test_backend_codex_models_data_keeps_only_list_visible_models tests/integration/test_v1_models.py::test_backend_codex_models_excludes_supported_in_api_false_models -q uv run ruff check app/modules/proxy/api.py tests/integration/test_path_rewrite_alias.py tests/integration/test_v1_models.py uv run ty check app/modules/proxy/api.py tests/integration/test_path_rewrite_alias.pyLocal result: 51 focused pytest cases passed; the deterministic backend Codex
alias regression pack passed; ruff, ty, and OpenSpec passed.