fix(api-keys): keep assigned account picker from closing dialog#1058
Open
laaichiu wants to merge 1 commit into
Open
fix(api-keys): keep assigned account picker from closing dialog#1058laaichiu wants to merge 1 commit into
laaichiu wants to merge 1 commit into
Conversation
Set the assigned-account dropdown to non-modal mode so its portaled menu does not trigger the parent API key dialog's outside-dismiss handling when focus returns to the form. Update the edit-dialog regression test to select accounts and click another in-dialog control before saving, proving the draft remains saveable without pressing Escape first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the assigned-account dropdown to non-modal mode so its portaled menu does not trigger the parent API key dialog's outside-dismiss handling when focus returns to the form.
Update the edit-dialog regression test to select accounts and click another in-dialog control before saving, proving the draft remains saveable without pressing Escape first.
Summary
Type of change
fix:— bug fix (no behavior change beyond the bug)feat:— new user-facing feature or capabilityrefactor:— internal refactor (no behavior change, no API change)docs:— documentation onlychore:/ci:/build:— tooling, CI, packagingtest:— test-only change!after the type, e.g.feat!:or includeBREAKING CHANGE:footer)Linked issue:
OpenSpec
shape, SSE framing, OAuth flow) and preserves upstream-equivalent behavior
Change directory:
Changes
Test plan
Screenshots / output (optional)
Checklist
<type>(<scope>)?: <subject>).uv run pre-commit run local-ci --hook-stage manual --all-filesor the relevantmake <target>subset locally.openspec validate --specspasses and/opsx:verifyis clean.