Fix PPR sampler memory and labeled homogeneous ABLP#645
Conversation
… into mkolodner-sc/ppr_gs_memory # Conflicts: # gigl/distributed/dist_ppr_sampler.py
|
/all_tests |
GiGL Automation@ 19:17:28UTC : 🔄 @ 19:19:34UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 19:17:29UTC : 🔄 @ 20:14:17UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 19:17:30UTC : 🔄 @ 20:47:24UTC : ❌ Workflow failed. |
GiGL Automation@ 19:17:30UTC : 🔄 @ 19:26:20UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 19:17:31UTC : 🔄 @ 20:30:59UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 19:17:31UTC : 🔄 @ 19:28:22UTC : ✅ Workflow completed successfully. |
|
/e2e_test |
GiGL Automation@ 20:48:41UTC : 🔄 @ 22:34:48UTC : ❌ Workflow failed. |
|
/e2e_test |
GiGL Automation@ 21:47:12UTC : 🔄 @ 23:07:38UTC : ❌ Workflow failed. |
|
/e2e_test |
GiGL Automation@ 22:42:25UTC : 🔄 @ 24:51:17UTC : ❌ Workflow failed. |
|
/e2e_test |
GiGL Automation@ 24:24:11UTC : 🔄 @ 01:47:47UTC : ❌ Workflow failed. |
|
/e2e_test |
GiGL Automation@ 24:38:06UTC : 🔄 @ 02:04:12UTC : ✅ Workflow completed successfully. |
kmontemayor2-sc
left a comment
kmontemayor2-sc
left a comment
There was a problem hiding this comment.
Thanks Matt! Did a first pass here, fwiw I feel like this could have been multiple PRs for the different fixes / etc but this pr is fine as-is.
mkolodner-sc
requested review from
nshah-sc,
svij-sc,
xgao4-sc and
zfan3-sc
as code owners
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
3 participants
Summary
Makes the PPR sampler cheaper and fixes the labeled-homogeneous ABLP edge case that surfaced while exercising PPR through Graph Store.
Changes include:
DistDataset.degree_tensor.int32and share them across sampling workers instead of rebuilding/copying per worker.DistPPRNeighborSamplerto consume precomputed degree tensors directly.etype=Nonefor true homogeneous graphs.Databatches.