Skip to content

[FEATURE] Performance improvement by skipping elasticsearch when SKU … #3766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lewisvoncken wants to merge 6 commits into
base: 2.11.x
Choose a base branch
from
Open

[FEATURE] Performance improvement by skipping elasticsearch when SKU … #3766

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0b3a05e
[FEATURE] Performance improvement by skipping elasticsearch when SKU …
lewisvoncken Dec 4, 2025
1be43c8
[BUGFIX] fix build error because of duplicate namespace by adding a p…
lewisvoncken Dec 4, 2025
5cb5412
[FEATURE] Added doc note for Magento search criteria builder
lewisvoncken Dec 4, 2025
dee0980
[FEATURE] Skip magento search directly get product
lewisvoncken Dec 4, 2025
6a2ec74
[FEATURE] Fix invalid array
lewisvoncken Dec 4, 2025
d0b6819
[FEATURE] added properties
lewisvoncken Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 89 additions & 6 deletions src/module-elasticsuite-catalog-graph-ql/Model/Resolver/Products.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@
use Smile\ElasticsuiteCatalogGraphQl\DataProvider\Product\SearchCriteriaBuilder;
use Smile\ElasticsuiteCatalogGraphQl\Model\Resolver\Products\ContextUpdater;
use Smile\ElasticsuiteCatalogGraphQl\Model\Resolver\Products\Query\Search;
use Magento\CatalogGraphQl\DataProvider\Product\SearchCriteriaBuilder as MagentoSearchCriteriaBuilder;
use Magento\CatalogGraphQl\Model\Resolver\Products\DataProvider\Deferred\Product as ProductDataProvider;
use Magento\CatalogGraphQl\Model\Resolver\Product\ProductFieldsSelector;
use Magento\CatalogGraphQl\Model\AttributesJoiner;

/**
* Elasticsuite custom implementation of GraphQL Products Resolver
Expand All @@ -32,7 +36,7 @@
* @package Smile\ElasticsuiteCatalogGraphQl
* @author Romain Ruaud <romain.ruaud@smile.fr>
*/
class Products implements ResolverInterface
class Products extends \Magento\CatalogGraphQl\Model\Resolver\Products implements ResolverInterface
{
/**
* @var ProductQueryInterface
Expand All @@ -50,15 +54,34 @@ class Products implements ResolverInterface
private $argsProcessor;

/**
* @param ProductQueryInterface $searchQuery Search Query
* @param ContextUpdater $contextUpdater Context Updater
* @param ArgumentsProcessorInterface|null $argumentProcessor Args Processor
* @var ProductDataProvider
*/
private $productDataProvider;

/**
* @var AttributesJoiner
*/
private $attributesJoiner;

/**
* @param ProductQueryInterface $searchQuery Search Query
* @param ContextUpdater $contextUpdater Context Updater
* @param ArgumentsProcessorInterface|null $argumentProcessor Args Processor
* @param MagentoSearchCriteriaBuilder|null $searchApiCriteriaBuilder Core SearchCriteria Builder
* @param ProductDataProvider|null $productDataProvider Product Data Provicer
* @param AttributesJoiner|null $attributesJoiner Attributes Joiner
*/
public function __construct(
ProductQueryInterface $searchQuery,
ContextUpdater $contextUpdater,
?ArgumentsProcessorInterface $argumentProcessor = null
?ArgumentsProcessorInterface $argumentProcessor = null,
?MagentoSearchCriteriaBuilder $searchApiCriteriaBuilder = null,
?ProductDataProvider $productDataProvider = null,
?AttributesJoiner $attributesJoiner = null
) {
parent::__construct($searchQuery, $searchApiCriteriaBuilder);
$this->productDataProvider = $productDataProvider ?? \Magento\Framework\App\ObjectManager::getInstance()->get(ProductDataProvider::class);
$this->attributesJoiner = $attributesJoiner ?? \Magento\Framework\App\ObjectManager::getInstance()->get(AttributesJoiner::class);
$this->searchQuery = $searchQuery;
$this->contextUpdater = $contextUpdater;
$this->argsProcessor = $argumentProcessor ?: ObjectManager::getInstance()->get(ArgumentsProcessorInterface::class);
Expand All @@ -71,14 +94,74 @@ public function resolve(Field $field, $context, ResolveInfo $info, ?array $value
{
$args = $this->getProcessedArgs($info, $args);
$this->validateArgs($args);
if (isset($args['filter']['sku'])) {
if (isset($args['filter']['sku']['eq'])) {
$sku = $args['filter']['sku']['eq'];
// Add product SKU and required fields to the data provider
$this->productDataProvider->addProductSku($sku);
$fields = $this->attributesJoiner->getQueryFields($info->fieldNodes[0]->selectionSet->selections[0], $info);
$this->productDataProvider->addEavAttributes($fields);

// Get product data synchronously
$productData = $this->productDataProvider->getProductBySku($sku);

if (empty($productData)) {
return [
'total_count' => 0,
'items' => [],
'suggestions' => [],
'page_info' => [
'page_size' => 1,
'current_page' => 1,
'total_pages' => 1,
'is_spellchecked' => false,
'query_id' => 0
],
'search_result' => null,
'layer_type' => Resolver::CATALOG_LAYER_CATEGORY,
];
}

// Format product data similar to how Products resolver returns it
/** @var \Magento\Catalog\Model\Product $productModel */
$productModel = $productData['model'];
$formattedProduct = $productModel->getData();
$formattedProduct['model'] = $productModel;

// Add custom attributes
if (!empty($productModel->getCustomAttributes())) {
foreach ($productModel->getCustomAttributes() as $customAttribute) {
if (!isset($formattedProduct[$customAttribute->getAttributeCode()])) {
$formattedProduct[$customAttribute->getAttributeCode()] = $customAttribute->getValue();
}
}
}

return [
'total_count' => 1,
'items' => [$formattedProduct],
'suggestions' => [],
'page_info' => [
'page_size' => 1,
'current_page' => 1,
'total_pages' => 1,
'is_spellchecked' => false,
'query_id' => 0
],
'search_result' => null,
'layer_type' => Resolver::CATALOG_LAYER_CATEGORY,
];
}
return parent::resolve($field, $context, $info, $value, $args);
}
$this->contextUpdater->updateSearchContext($args);

$searchResult = $this->searchQuery->getResult($args, $info, $context);
$layerType = Resolver::CATALOG_LAYER_CATEGORY;

if (isset($args['search']) && (!empty($args['search']))) {
$layerType = Resolver::CATALOG_LAYER_SEARCH;
}
}

return [
'total_count' => $searchResult->getTotalCount(),
Expand Down
Loading