Optimize universal block detection to avoid expensive NBT lookups - #1222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
StorageCacheUtils.hasUniversalBlock(Location)insrc/main/java/com/xzavier0722/mc/plugin/slimefun4/storage/util/StorageCacheUtils.javato first check the in-memory universal block cache before any NBT lookup.Slimefun.getBlockDataService().isTileEntity(...)to immediately returnfalsefor non-tile blocks.getUniversalDataUUIDcall behindTaskUtil.runSyncMethod(...)and only execute it when the block is a tile-entity and not present in the cache.Testing
git diff --checkwithout issues../gradlew compileJavabut the Gradle distribution download was blocked by the environment proxy (HTTP 403), so a full compile could not be completed.mvn -q -DskipTests compileis not applicable because the repository uses Gradle and there is no top-levelpom.xml.Codex Task