BUG: Fix range shifter placement and 3D centering on ion plan import - #344
Open
xskere wants to merge 1 commit into
Open
BUG: Fix range shifter placement and 3D centering on ion plan import#344xskere wants to merge 1 commit into
xskere wants to merge 1 commit into
Conversation
Two problems left imported proton plans with their range shifters in the wrong place and the 3D view unable to center on the patient: First, the dynamic beam sequence import applied the isocenter translation twice: once while updating the beam transform and again explicitly afterward. This placed every imported beam and its range shifter at twice the isocenter offset, more than a metre from the patient. The redundant second translation has been removed so imported beams and range shifters sit at their correct location. Second, a retracted range shifter was drawn shifted sideways off the beam axis, which pushed it outside the field of view and further skewed the automatic centering. The range shifter model now always stays on the beam axis, and whether it is retracted or inserted is conveyed through its transparency rather than it being moved out of position. Re SlicerRt#330
Member
|
If @ferdymercury agrees then we can integrate. Thank you! |
ferdymercury
approved these changes
Aug 3, 2026
ferdymercury
left a comment
ferdymercury
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot!
Not sure if the RangeShifter Opacity settings could be configured via two GUI buttons ? Or is hard-coded 0.05 vs 0.3 good enough ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two problems left imported proton plans with their range shifters in the wrong place and the 3D view unable to center on the patient:
First, the dynamic beam sequence import applied the isocenter translation twice: once while updating the beam transform and again explicitly afterward. This placed every imported beam and its range shifter at twice the isocenter offset, more than a metre from the patient. The redundant second translation has been removed so imported beams and range shifters sit at their correct location.
Second, a retracted range shifter was drawn shifted sideways off the beam axis, which pushed it outside the field of view and further skewed the automatic centering. The range shifter model now always stays on the beam axis, and whether it is retracted or inserted is conveyed through its transparency rather than it being moved out of position.
Re #330