chore(deps): bump sharp and looks-same - #39
Conversation
Bumps [sharp](https://github.com/lovell/sharp) and [looks-same](https://github.com/gemini-testing/looks-same). These dependencies needed to be updated together. Updates `sharp` from 0.34.3 to 0.35.3 - [Release notes](https://github.com/lovell/sharp/releases) - [Commits](lovell/sharp@v0.34.3...v0.35.3) Updates `looks-same` from 9.0.0 to 10.0.1 - [Release notes](https://github.com/gemini-testing/looks-same/releases) - [Changelog](https://github.com/gemini-testing/looks-same/blob/master/CHANGELOG.md) - [Commits](gemini-testing/looks-same@v9.0.0...v10.0.1) --- updated-dependencies: - dependency-name: sharp dependency-version: 0.35.3 dependency-type: direct:production - dependency-name: looks-same dependency-version: 10.0.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
📝 WalkthroughWalkthroughChangesDependency version updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
package.jsonOops! Something went wrong! :( ESLint: 8.57.1 Error: ESLint configuration in --config is invalid:
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 99: Update the package.json engines.node requirement from Node.js >=18 to
>=20.9.0 to match sharp@0.35.3, while preserving the existing sharp dependency
declaration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 893f65e0-30e4-4f54-b821-fff7ad172c83
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
| "color-string": "^1.9.1", | ||
| "js-base64": "^3.7.7", | ||
| "sharp": "^0.34.3" | ||
| "sharp": "^0.35.3" |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
npm view sharp@0.35.3 engines --json
rg -n '"node"\s*:' package.jsonRepository: Short-io/qreator
Length of output: 394
Raise the Node.js engine to match sharp@0.35.3.
sharp@0.35.3 requires Node.js >=20.9.0, but this package still advertises >=18. Node 18 consumers can pass the engine check and then fail to install or load sharp.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@package.json` at line 99, Update the package.json engines.node requirement
from Node.js >=18 to >=20.9.0 to match sharp@0.35.3, while preserving the
existing sharp dependency declaration.
Bumps sharp and looks-same. These dependencies needed to be updated together.
Updates
sharpfrom 0.34.3 to 0.35.3Release notes
Sourced from sharp's releases.
... (truncated)
Commits
1018449Release v0.35.3ba303a7Prerelease v0.35.3-rc.24f94fc5Upgrade to sharp-libvips v1.3.2c5e7a3fBump devDeps, fix Deno/Windows smoke tests9a8d002Docs: Add changelog entry and note about transferable #45208694db0TypeScript: Return more preciseBuffer\<ArrayBuffer>fromtoBuffer(#4520)e000d0bPrerelease v0.35.3-rc.19554ca9Prerelease v0.35.3-rc.06a29fd5Emit warning about native binaries on Linux Electron540d2eaIncrease default concurrency when use of MALLOC_ARENA_MAX detectedMaintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for sharp since your current version.
Updates
looks-samefrom 9.0.0 to 10.0.1Release notes
Sourced from looks-same's releases.
... (truncated)
Changelog
Sourced from looks-same's changelog.
Commits
aa0be3710.0.1be61eecMerge pull request #115 from gemini-testing/TESTPLANE-653.refactorfb640e9refactor: use buffer subarrays7e12fe8chore(release): 10.0.007665fcMerge pull request #114 from gemini-testing/TRIVIAL.remove_extra_deps28533c1chore: remove extra depsfbd86dfMerge pull request #113 from gemini-testing/TESTPLANE-653.bin982b367docs(benchmark): update benchmarks89cf122chore!: migrate sharp -> jsquash/pngea3dc47chore: reduce deps sizeDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Summary by CodeRabbit