Restore window scope for several workspace specific settings

[i10416]

Motivation

With capabilities.untrustedWorkspaces.restrictedConfigurations It seems impossible to set customRubyCommand at workspace level because VS Code prevents the extension from reading the machine scope options in workspace's .vscode/settings.json.

It fails with Automatic Ruby environment activation with custom failed: Command failed: && ruby -EUTF-8:UTF-8 '/path/to/.vscode/extensions/shopify.ruby-lsp-0.10.4/activation.rb' zsh:1: parse error near &&' because the command here becomes && ruby - ....

ruby-lsp/vscode/src/ruby/custom.ts

Line 12 in 4c109e3

const parsedResult = await this.runEnvActivationScript(`${this.customCommand()} && ruby`);

It is sometimes case with me to find two ruby projects use different tools to manage ruby.

This change allows users to change some workspace specific settings for each workspace.

Related to

• Problem with projects using different ruby versions opened in one workspace in VSC #4119
• Settings no longer allowed in workspace #4114

Implementation

Change option scope from "machine" to "machine-configurable"

Automated Tests

Manual Tests

Add the following .vscode/settings.json to your workspace and enable the extension.

{
  "rubyLsp.rubyVersionManager": {
    "identifier": "custom"
  },
  "rubyLsp.customRubyCommand": "{any command of your choice}"
}

[i10416]

Just signed CLA

[i10416]

BTW, this is never true because workspace.getConfiguration(...).get(...) returns default value for some primitive types;

ruby-lsp/vscode/src/ruby/custom.ts

Line 26 in 4c109e3

if (customCommand === undefined) {

microsoft/vscode#123957 (comment)

It must use inspect method to detect null value.

[i10416]

or window?

https://code.visualstudio.com/api/references/contribution-points#:~:text=A%20configuration%20setting%20can%20have%20one%20of%20the%20following%20possible%20scopes:

[i10416]

Ruby version manager could be different depending on workspaces.

[i10416]

It is safe to use window scope because untrusted workspace cannot execute command thanks to capabilities.untrustedWorkspaces options.