Move the most of metadata into PEP 621-compliant pyproject.toml.#1006
Merged
Conversation
Add `pyproject.toml` according to PEP 517.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## devel #1006 +/- ##
=======================================
Coverage 54.49% 54.49%
=======================================
Files 210 210
Lines 21560 21560
Branches 3169 3169
=======================================
Hits 11750 11750
Misses 9255 9255
Partials 555 555 |
|
It partially overlaps with #975, I think. |
Contributor
Member
|
I'd be supportive of this. |
Contributor
|
Yes pls update the branch and we need to merge it. |
MartinBubel
requested changes
Mar 26, 2024
MartinBubel
left a comment
MartinBubel
left a comment
Contributor
There was a problem hiding this comment.
LGTM, only some minor things to be done
| authors = [{name = "GPy Authors: https://github.com/SheffieldML/GPy/graphs/contributors", email = "gpy.authors@gmail.com"},] | ||
| license = {text = "BSD-3-Clause"} | ||
| description = "The Gaussian Process Toolbox" | ||
| readme = "README.rst" |
Contributor
There was a problem hiding this comment.
Suggested change
| readme = "README.rst" | |
| readme = "README.md" |
Comment on lines
+18
to
+22
| "Programming Language :: Python :: 3.5", | ||
| "Programming Language :: Python :: 3.6", | ||
| "Programming Language :: Python :: 3.7", | ||
| "Programming Language :: Python :: 3.8", | ||
| "Programming Language :: Python :: 3.9", |
Contributor
There was a problem hiding this comment.
Suggested change
| "Programming Language :: Python :: 3.5", | |
| "Programming Language :: Python :: 3.6", | |
| "Programming Language :: Python :: 3.7", | |
| "Programming Language :: Python :: 3.8", | |
| "Programming Language :: Python :: 3.9", | |
| "Programming Language :: Python :: 3.9", | |
| "Programming Language :: Python :: 3.10", | |
| "Programming Language :: Python :: 3.11", | |
| "Programming Language :: Python :: 3.12", | |
| "Programming Language :: Python :: 3.13", |
Comment on lines
+34
to
+35
| "scipy>=1.3.0; python_version >= '3.6'", | ||
| "scipy>=1.3.0,<1.5.0; python_version < '3.6'", |
Contributor
There was a problem hiding this comment.
Suggested change
| "scipy>=1.3.0; python_version >= '3.6'", | |
| "scipy>=1.3.0,<1.5.0; python_version < '3.6'", | |
| "scipy>=1.3.0,<=1.12.0" |
| dependencies = [ | ||
| "numpy>=1.7", | ||
| "six", | ||
| "paramz>=0.9.0", |
Contributor
There was a problem hiding this comment.
Suggested change
| "paramz>=0.9.0", | |
| "paramz>=0.9.6", |
Comment on lines
+49
to
+50
| "matplotlib==3.3.4; python_version >= '3.6'", | ||
| "matplotlib==3.0.0; python_version < '3.6'", |
Contributor
There was a problem hiding this comment.
Suggested change
| "matplotlib==3.3.4; python_version >= '3.6'", | |
| "matplotlib==3.0.0; python_version < '3.6'", | |
| "matplotlib>=3.3.4", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #1005