fix(runtime): pin docker image builder release#14
Merged
Conversation
abd22df to
44d004b
Compare
44d004b to
0a9f4d3
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the AgentRun CLI runtime cloud-build helper to pin the docker-image-builder download to a specific release tag and verify the pinned artifacts via embedded SHA256 digests, while still supporting a custom DOCKER_IMAGE_BUILDER_BINTAG override (verified via the tag’s sibling .sha256 file).
Changes:
- Pinned the default docker-image-builder release tag and added embedded SHA256 digests for supported artifacts.
- Routed checksum selection through a new helper that uses embedded digests for the pinned tag and remote
.sha256for custom tags. - Updated unit tests for pinned/default vs custom-tag behavior, and adjusted runtime docs (though the current doc diff removes important user-facing details that should be retained/updated).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/agentrun_cli/_utils/cloud_build.py |
Pins builder tag, adds embedded SHA256 map, and selects expected digest based on pinned vs custom tag. |
tests/unit/test_cloud_build.py |
Updates tests to validate pinned-tag behavior uses embedded digests and custom tags still use remote .sha256. |
docs/en/runtime.md |
Removes the docker-image-builder download/verification and override documentation (should be updated to reflect new pinned + embedded SHA behavior). |
docs/zh/runtime.md |
Removes the docker-image-builder download/verification and override documentation (should be updated to reflect new pinned + embedded SHA behavior). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: 117503445 <t117503445@gmail.com>
0a9f4d3 to
aef653d
Compare
Sodawyx
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation