Bench: Restore Default Signals And Amplify Short Metrics#190
Merged
Conversation
bench-todo.js and bench-hydrate.js had drifted onto the krausest specialized signal config. The suite was measuring three cells of the no-clone fast path and zero cells of the user-facing default path, conflating two questions the in-flight signals PR needs to answer separately. Strip the drift from todo and hydrate so they test what users run. krausest and bench-stable-ref keep their pinned configs as the specialized showcase tests they're named for. Amplify ~18 short metrics whose post-PR-#187 means landed under the σ≈2ms physical noise floor. The workloads were rAF-bound before, so apparent means tracked frame cadence rather than work; with sync flush they now show real per-iteration cost. Iteration counts sized for the current tiny means hold up post-#150 since reference/freeze defaults are at-most as expensive as the current path. Renames follow the suffix-iteration-count convention in extend-bench-suite. Bench-history resets cleanly for renamed metrics.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This swaps many signals in bench to use default args except krausest which is designed to showcase performance and use optimized signal config.
This also amplifies 18 bench that were below noise ceiling
Changes
Risk
0/10 - CI only