-
Notifications
You must be signed in to change notification settings - Fork 36
refactor: casl factory - attachments #2773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HayenNico
wants to merge
3
commits into
refactor-casl-factory-cleanup
Choose a base branch
from
refactor-casl-factory-attachments
base: refactor-casl-factory-cleanup
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| import { | ||
| AbilityBuilder, | ||
| ExtractSubjectType, | ||
| MongoAbility, | ||
| createMongoAbility, | ||
| } from "@casl/ability"; | ||
| import { Injectable } from "@nestjs/common"; | ||
| import { ConfigService } from "@nestjs/config"; | ||
| import { AccessGroupsType } from "src/config/configuration"; | ||
| import { Action } from "../action.enum"; | ||
| import { | ||
| Subjects, | ||
| PossibleAbilities, | ||
| Conditions, | ||
| } from "../types/casl-subjects"; | ||
| import { JWTUser } from "src/auth/interfaces/jwt-user.interface"; | ||
| import { Attachment } from "src/attachments/schemas/attachment.schema"; | ||
|
|
||
| @Injectable() | ||
| export class AttachmentAbility { | ||
| constructor(private configService: ConfigService) { | ||
| this.accessGroups = | ||
| this.configService.get<AccessGroupsType>("accessGroups"); | ||
| } | ||
| private accessGroups; | ||
|
|
||
| buildAbility(user: JWTUser): MongoAbility<PossibleAbilities, Conditions> { | ||
| const { can, build } = new AbilityBuilder( | ||
| createMongoAbility<PossibleAbilities, Conditions>, | ||
| ); | ||
| const ifPublished = { isPublished: true }; | ||
|
|
||
| /** | ||
| * Unauthenticated user | ||
| */ | ||
| can(Action.AttachmentRead, Attachment, ifPublished); | ||
|
|
||
| if (!user) { | ||
| return build({ | ||
| detectSubjectType: (item) => | ||
| item.constructor as ExtractSubjectType<Subjects>, | ||
| }); | ||
| } | ||
|
|
||
| const ifOwner = { ownerGroup: { $in: user.currentGroups } }; | ||
| const ifAccess = { accessGroups: { $in: user.currentGroups } }; | ||
|
|
||
| /** | ||
| * Authenticated user | ||
| */ | ||
| can(Action.AttachmentRead, Attachment, ifOwner); | ||
| can(Action.AttachmentRead, Attachment, ifAccess); | ||
| can(Action.AttachmentRead, Attachment, ifPublished); | ||
|
|
||
| if ( | ||
| user.currentGroups.some((g) => | ||
| this.accessGroups?.attachment.includes(g), | ||
| ) || | ||
| this.accessGroups?.attachment.includes("#all") | ||
| ) { | ||
| /** | ||
| * User belonging to ATTACHMENT_GROUPS | ||
| */ | ||
| can(Action.AttachmentCreate, Attachment, ifOwner); | ||
| can(Action.AttachmentUpdate, Attachment, ifOwner); | ||
| can(Action.AttachmentDelete, Attachment, ifOwner); | ||
| } | ||
|
|
||
| if ( | ||
| user.currentGroups.some((g) => | ||
| this.accessGroups?.attachmentPrivileged.includes(g), | ||
| ) | ||
| ) { | ||
| /** | ||
| * User belonging to ATTACHMENT_PRIVILEGED_GROUPS | ||
| */ | ||
| can(Action.AttachmentCreate, Attachment); | ||
| can(Action.AttachmentUpdate, Attachment, ifOwner); | ||
| can(Action.AttachmentDelete, Attachment, ifOwner); | ||
| } | ||
|
|
||
| if (user.currentGroups.some((g) => this.accessGroups?.admin.includes(g))) { | ||
| /** | ||
| * User belonging to ADMIN_GROUPS | ||
| */ | ||
| can(Action.AccessAny, Attachment); | ||
|
|
||
| can(Action.AttachmentCreate, Attachment); | ||
| can(Action.AttachmentRead, Attachment); | ||
| can(Action.AttachmentUpdate, Attachment); | ||
| can(Action.AttachmentDelete, Attachment); | ||
| } | ||
|
|
||
| if (user.currentGroups.some((g) => this.accessGroups?.delete.includes(g))) { | ||
| /** | ||
| * User belonging to DELETE_GROUPS | ||
| */ | ||
| can(Action.AttachmentDelete, Attachment); | ||
| } | ||
|
|
||
| return build({ | ||
| detectSubjectType: (item) => | ||
| item.constructor as ExtractSubjectType<Subjects>, | ||
| }); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Using
AttachmentReadwith a class subject while the rule has instance-level conditions may cause unexpected guard behavior for unauthenticated requests.In
attachmentAccess, unauthenticated users are grantedcan(Action.AttachmentRead, Attachment, { isPublished: true }), butCheckPoliciesis now callingability.can(Action.AttachmentRead, Attachment)with the class as subject. Depending on howPoliciesGuard/CASL treat class subjects, theisPublishedcondition may never be applied, which could either unintentionally block previously allowed unauthenticated reads or, worse, bypass the condition and allow more than intended. To avoid changing behavior, either:can(Action.AttachmentRead, Attachment)rule specifically for endpoint-level checks, and keep{ isPublished: true }for instance-level filtering, orPoliciesGuardto evaluate this permission against a representativeAttachmentinstance instead of the class.