-
Notifications
You must be signed in to change notification settings - Fork 45
feat: make the hash input cast datatype configurable per adapter #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7d84d88
feat: make the hash input cast datatype configurable per adapter
tkirschke 1c80e37
Potential fix for pull request finding
tkirschke ea001ed
Potential fix for pull request finding
tkirschke b82cdca
Merge branch 'main' into feat/configurable-hash-input-dtype
tkiehn fd6ee17
adjust docs and warnings for TSQL adapters
tkiehn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| {# | ||
| Returns the string datatype that hash inputs are casted to, before they are handed over to the hash function. | ||
|
|
||
| Two different casts exist, which can be configured independently: | ||
| - 'attribute': The cast of one single column inside `attribute_standardise`. | ||
| - 'concat': The cast of the fully concatenated payload inside `concattenated_standardise`. | ||
|
|
||
| Multi Active Satellites are deliberately NOT covered here. Their payload is aggregated across all | ||
| active records of one group before it is hashed, so a shortened datatype is far more likely to be | ||
| exceeded there. `multi_active_concattenated_standardise` therefore keeps its hardcoded datatype. | ||
|
|
||
| CAUTION: Choosing a datatype that is shorter than the actual hash input leads to a silent | ||
| truncation on most adapters, which changes the resulting hash values. | ||
| #} | ||
|
|
||
| {%- macro hash_input_dtype(type='concat') %} | ||
|
|
||
| {{ return(adapter.dispatch('hash_input_dtype', 'datavault4dbt')(type=type)) }} | ||
|
|
||
| {%- endmacro -%} | ||
|
|
||
|
|
||
| {%- macro default__hash_input_dtype(type) %} | ||
|
|
||
| {%- if type == 'attribute' -%} | ||
| {%- set var_name = 'datavault4dbt.hash_input_attribute_dtype' -%} | ||
| {%- set fallbacks = {"bigquery": "STRING", "snowflake": "STRING", "exasol": "VARCHAR(20000) UTF8", "postgres": "VARCHAR", "synapse": "VARCHAR(4000)", "fabric": "VARCHAR(4000)", "oracle": "VARCHAR2(2000)", "databricks": "STRING", "trino": "VARCHAR", "sqlserver": "VARCHAR(MAX)"} -%} | ||
| {%- else -%} | ||
| {%- set var_name = 'datavault4dbt.hash_input_concat_dtype' -%} | ||
| {%- set fallbacks = {"bigquery": "STRING", "snowflake": "STRING", "exasol": "VARCHAR(2000000) UTF8", "postgres": "VARCHAR", "redshift": "VARCHAR", "synapse": "VARCHAR(4000)", "fabric": "VARCHAR(4000)", "oracle": "VARCHAR2(2000)", "databricks": "STRING", "trino": "VARCHAR", "sqlserver": "VARCHAR(MAX)"} -%} | ||
| {%- endif -%} | ||
|
|
||
| {%- set global_var = var(var_name, none) -%} | ||
|
|
||
| {%- if global_var is mapping and target.type in global_var.keys()|map('lower') -%} | ||
|
|
||
| {%- set hash_input_dtype = global_var[target.type] -%} | ||
|
|
||
| {%- elif global_var is not mapping and datavault4dbt.is_something(global_var) -%} | ||
|
|
||
| {%- set hash_input_dtype = global_var -%} | ||
|
|
||
| {%- else -%} | ||
|
|
||
| {%- set hash_input_dtype = fallbacks.get(target.type, 'STRING') -%} | ||
|
|
||
| {%- if execute -%} | ||
| {%- do exceptions.warn("Warning: Adapter '"~ target.type ~"' not found in '" ~ var_name ~ "' variable. Defaulting to '" ~ hash_input_dtype ~ "'.") -%} | ||
| {%- endif -%} | ||
|
|
||
| {%- endif -%} | ||
|
Copilot marked this conversation as resolved.
|
||
|
|
||
| {{ return(hash_input_dtype) }} | ||
|
|
||
| {%- endmacro -%} | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.