Skip to content

conn.go, handler.go: Added SystemUptime tracking and method to Conn.#57

Open
TrippleAWap wants to merge 1 commit into
Sandertv:masterfrom
TrippleAWap:feat/system-uptime
Open

conn.go, handler.go: Added SystemUptime tracking and method to Conn.#57
TrippleAWap wants to merge 1 commit into
Sandertv:masterfrom
TrippleAWap:feat/system-uptime

Conversation

@TrippleAWap

Copy link
Copy Markdown
Contributor

No description provided.

@cooldogedev cooldogedev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, systemStart is only set for listeners. It should also be set for dialers.

@TrippleAWap

Copy link
Copy Markdown
Contributor Author

Currently, systemStart is only set for listeners. It should also be set for dialers.

There's issues concerning this considering not all implementations of RakNet are 1-1 with Minecraft Bedrock and serve the wrong timestamp (CloudburstMC/Network#61) however, I can still add this if we believe it should still be added.

@TrippleAWap

Copy link
Copy Markdown
Contributor Author

Currently, systemStart is only set for listeners. It should also be set for dialers.

There's issues concerning this considering not all implementations of RakNet are 1-1 with Minecraft Bedrock and serve the wrong timestamp (CloudburstMC/Network#61) however, I can still add this if we believe it should still be added.

I'm not opposed to adding it as it still serves a purpose for BDS and servers using go-raknet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants