Skip to content

[MPQEditor] Implement 'findMPQName'#1518

Merged
seanshpark merged 1 commit into
Samsung:mainfrom
stamalakhov:manual_MPQ_findMPQName_br
Apr 6, 2023
Merged

[MPQEditor] Implement 'findMPQName'#1518
seanshpark merged 1 commit into
Samsung:mainfrom
stamalakhov:manual_MPQ_findMPQName_br

Conversation

@stamalakhov

Copy link
Copy Markdown
Contributor

This commit implements 'findMPQName' and adds tests for it.

Fresh draft: #1511
Previous draft: #1505
Related: #1491

ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov s.malakhov@partner.samsung.com

@stamalakhov
stamalakhov requested a review from seanshpark April 5, 2023 10:12
@stamalakhov stamalakhov self-assigned this Apr 5, 2023
Comment thread src/MPQEditor/MPQEditor.ts Outdated
@stamalakhov
stamalakhov force-pushed the manual_MPQ_findMPQName_br branch 2 times, most recently from 911f653 to b3f77f4 Compare April 6, 2023 07:07
Comment thread src/MPQEditor/MPQEditor.ts Outdated
seanshpark
seanshpark previously approved these changes Apr 6, 2023

@seanshpark seanshpark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This commit implements 'findMPQName' and adds tests for it.

ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov <s.malakhov@partner.samsung.com>

@seanshpark seanshpark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@seanshpark
seanshpark merged commit 08972a3 into Samsung:main Apr 6, 2023
@stamalakhov
stamalakhov deleted the manual_MPQ_findMPQName_br branch April 6, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants