Skip to content

Stamp fix - #868

Merged
danielpeter merged 2 commits into
SPECFEM:develfrom
lsawade:stamp-fix
Dec 16, 2025
Merged

Stamp fix#868
danielpeter merged 2 commits into
SPECFEM:develfrom
lsawade:stamp-fix

Conversation

@lsawade

@lsawade lsawade commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

Hi Daniel, Just a small fix for putting the stamp value to south pole.

@codecov

codecov Bot commented Dec 15, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.06%. Comparing base (11af3c6) to head (a34415e).
⚠️ Report is 20 commits behind head on devel.

Files with missing lines Patch % Lines
src/auxiliaries/create_movie_GMT_global.f90 0.00% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #868      +/-   ##
==========================================
- Coverage   37.06%   37.06%   -0.01%     
==========================================
  Files         295      295              
  Lines       68633    68676      +43     
==========================================
+ Hits        25440    25452      +12     
- Misses      43193    43224      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danielpeter
danielpeter merged commit dd9b3d7 into SPECFEM:devel Dec 16, 2025
33 of 35 checks passed
@danielpeter

Copy link
Copy Markdown
Member

thanks! not sure if it makes much difference. these stamps could be placed anywhere. the idea of having them at opposite poles is just to place them somewhere away from the more interesting visual areas in the middle of the image.

@lsawade

lsawade commented Dec 17, 2025

Copy link
Copy Markdown
Contributor Author

Yes, it was just an eyesore for the globe display interpolated wavefield. I'm likely going to create a follow-up PR where I'm writing min/max values to a separate file on a per snapshot basis to normalize the wavefield with a moving average for the display without the need for stamping. since the southpole is still visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants