Skip to content

updates cuda device properties, and NaN checks for EMC models #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielpeter merged 2 commits into from
Sep 17, 2025
Merged

updates cuda device properties, and NaN checks for EMC models #863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d48148
updates deviceOverlap handling
danielpeter Sep 16, 2025
b32c591
updates NaN check for EMC model
danielpeter Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/gpu/initialize_gpu.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,11 +350,16 @@ static void output_cuda_device_infos(int myrank){
}else{
fprintf(fp," canMapHostMemory: FALSE\n");
}
if (deviceProp.deviceOverlap) {
#if CUDA_VERSION < 13000 || (defined (__CUDACC_VER_MAJOR__) && (__CUDACC_VER_MAJOR__ < 13))
if (deviceProp.deviceOverlap){
fprintf(fp," deviceOverlap: TRUE\n");
}else{
fprintf(fp," deviceOverlap: FALSE\n");
}
#else
// CUDA version >= 13, deviceOverlap deprecated, replaced by asyncEngineCount
fprintf(fp," asyncEngineCount: %d\n", deviceProp.asyncEngineCount);
#endif
if (deviceProp.concurrentKernels) {
fprintf(fp," concurrentKernels: TRUE\n");
}else{
Expand Down
63 changes: 55 additions & 8 deletions src/meshfem3D/model_EMC.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,6 +716,8 @@ end subroutine check_dimorder
! --------------------------------
subroutine check_variable_attributes(ncid, varid, unit, direction, missing_val)

use, intrinsic :: ieee_arithmetic

implicit none
integer, intent(in) :: ncid
integer, intent(in) :: varid
Expand All @@ -724,14 +726,18 @@ subroutine check_variable_attributes(ncid, varid, unit, direction, missing_val)
! local parameters
integer :: num_atts,i
character(len=100) :: name,value
real(kind=CUSTOM_REAL) :: fill_val
real(kind=CUSTOM_REAL) :: fill_val,val_read
logical :: has_fill_value,has_missing_value

! note: isNaN() function is a GNU extension, thus not all compilers might have it.
! using a simple val /= val check can already work.
! here, we double-check with the IEEE intrinsic function ieee_is_nan() which should be Fortran2003 standard.

! initializes
unit = 0
direction = 0
missing_val = 9999.0_CUSTOM_REAL
fill_val = 9999.0_CUSTOM_REAL
missing_val = 99999.0_CUSTOM_REAL ! initializes to some ficticious value
fill_val = 99999.0_CUSTOM_REAL

has_missing_value = .false.
has_fill_value = .false.
Expand Down Expand Up @@ -804,22 +810,47 @@ subroutine check_variable_attributes(ncid, varid, unit, direction, missing_val)
endif

else if (trim(name) == 'missing_value') then
! initialize to avoid issues with netcdf function call
val_read = 0.0_CUSTOM_REAL
! assigns value for invalid entries
call check_status(nf90_get_att(ncid, varid, name, missing_val))
if (VERBOSE) print *,' missing value: ',missing_val
call check_status(nf90_get_att(ncid, varid, name, val_read))
if (VERBOSE) print *,' missing value: ',val_read
! to avoid compiler running into floating-point invalid errors, we double-check if value is not-a-number
has_missing_value = .true.
! isNaN check
if (val_read /= val_read) then
! NaN value
has_missing_value = .false.
else
has_missing_value = .true.
endif
! double-check with ieee function
if (ieee_support_standard(val_read)) then
if (ieee_is_nan(val_read)) has_missing_value = .false.
endif
! only assign if not NaN
if (has_missing_value) missing_val = val_read

else if (trim(name) == '_FillValue' .or. trim(name) == 'FillValue') then
! initialize to avoid issues with netcdf function call
val_read = 0.0_CUSTOM_REAL
! assigns value for invalid entries
call check_status(nf90_get_att(ncid, varid, name, fill_val))
if (VERBOSE) print *,' fill value: ',fill_val
call check_status(nf90_get_att(ncid, varid, name, val_read))
if (VERBOSE) print *,' fill value: ',val_read
! to avoid compiler running into floating-point invalid errors, we double-check if value is not-a-number
has_fill_value = .true.
! isNaN check
if (fill_val /= fill_val) then
if (val_read /= val_read) then
! NaN value
has_fill_value = .false.
else
has_fill_value = .true.
endif
! double-check with ieee function
if (ieee_support_standard(val_read)) then
if (ieee_is_nan(val_read)) has_fill_value = .false.
endif
if (has_fill_value) fill_val = val_read

else if (trim(name) == 'long_name' .or. trim(name) == '_long_name') then
! assigns value for invalid entries
Expand Down Expand Up @@ -2887,6 +2918,22 @@ subroutine read_emc_model()
double precision, parameter :: RCMB_ = 3480000.d0
double precision, parameter :: R_EARTH_ = 6371000.d0

! initializes
dir_dep = 0
dir = 0

missing_val_vp = 99999.0_CUSTOM_REAL ! initializes to some ficticious value
missing_val_vs = 99999.0_CUSTOM_REAL
missing_val_rho = 99999.0_CUSTOM_REAL
missing_val_dep = 99999.0_CUSTOM_REAL

missing_val_vpv = 99999.0_CUSTOM_REAL
missing_val_vph = 99999.0_CUSTOM_REAL
missing_val_vsv = 99999.0_CUSTOM_REAL
missing_val_vsh = 99999.0_CUSTOM_REAL
missing_val_eta = 99999.0_CUSTOM_REAL
missing_val_qmu = 99999.0_CUSTOM_REAL

if (VERBOSE) print *,'reading EMC model:'

! Open netcdf file with write access
Expand Down
5 changes: 5 additions & 0 deletions utils/GPU_tools/check_cuda_device.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,11 +282,16 @@ e.g., on titan enable environment CRAY_CUDA_MPS=1 to use a single GPU with multi
}else{
printf(" canMapHostMemory: FALSE\n");
}
#if CUDA_VERSION < 13000 || (defined (__CUDACC_VER_MAJOR__) && (__CUDACC_VER_MAJOR__ < 13))
if(deviceProp.deviceOverlap){
printf(" deviceOverlap: TRUE\n");
}else{
printf(" deviceOverlap: FALSE\n");
}
#else
// CUDA version >= 13, deviceOverlap deprecated, replaced by asyncEngineCount
printf(" asyncEngineCount: %d\n", deviceProp.asyncEngineCount);
#endif
fflush(stdout);


Expand Down
6 changes: 6 additions & 0 deletions ...em3D_globe_simple_demo_code_for_GPUs_in_C_and_CUDA_with_fault_tolerance_library_nov2011.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,10 +207,16 @@ int main(int argc, char *argv[])
else
{ printf("canMapHostMemory: FALSE\n"); }

#if CUDA_VERSION < 13000 || (defined (__CUDACC_VER_MAJOR__) && (__CUDACC_VER_MAJOR__ < 13))
if(deviceProp.deviceOverlap)
{ printf("deviceOverlap: TRUE\n"); }
else
{ printf("deviceOverlap: FALSE\n"); }
#else
// CUDA version >= 13, deviceOverlap deprecated, replaced by asyncEngineCount
printf(" asyncEngineCount: %d\n", deviceProp.asyncEngineCount);
#endif

#endif

// make sure that the device has compute capability >= 1.3
Expand Down
Loading