feat: Merge View (RDFA-344) - #176
Merged
Merged
Conversation
…s-profile-diagrams # Conflicts: # frontend/src/routes/mainpage/packageNavigation/DatasetSection.svelte
…s-profile-diagrams # Conflicts: # backend/src/main/java/org/rdfarchitect/database/inmemory/GraphWithContext.java # backend/src/main/java/org/rdfarchitect/database/inmemory/GraphWithContextCollection.java # backend/src/main/java/org/rdfarchitect/database/inmemory/InMemoryDatabase.java # backend/src/main/java/org/rdfarchitect/database/inmemory/InMemoryDatabaseImpl.java # backend/src/main/java/org/rdfarchitect/database/inmemory/SessionDataStore.java # backend/src/main/java/org/rdfarchitect/services/diagrams/CustomDiagramService.java # backend/src/main/java/org/rdfarchitect/services/dl/select/QueryDiagramLayoutService.java # backend/src/main/java/org/rdfarchitect/services/dl/update/UpdateDiagramLayoutService.java # backend/src/main/java/org/rdfarchitect/services/dl/update/classlayout/UpdateClassLayoutService.java # frontend/src/lib/rendering/svelteflow/components/SvelteFlowClassContextMenu.svelte
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Signed-off-by: Philipp Kirchner <philipp.kirchner@soptim.de>
rema-soptim
requested changes
Jun 18, 2026
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> Signed-off-by: Philipp Kirchner <philipp.kirchner@soptim.de>
Collaborator
|
rema-soptim
requested changes
Jun 25, 2026
rema-soptim
left a comment
rema-soptim
left a comment
Collaborator
There was a problem hiding this comment.
- When a class is renamed to something that does not exist yet an new mergedClassEditor is created. this new mergedClassEditor then has the dl position of (i guess) 0,0, which moves the currently selected class away. I think it should just keep the dl-x/y of the old mergedClassEditor and the z index + 1. If the z index is too complicated i'd just move it to max-z+1.
- There is no context menu in the mergedClassView to edit the dl-z index
…s-profile-diagrams # Conflicts: # backend/src/main/java/org/rdfarchitect/services/dl/select/QueryDiagramLayoutService.java
rema-soptim
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the Merge View. In the merge view all classes of an dataset are merged based on their URI and displayed in one diagram.
Related Issues
Checklist
git commit -s) for DCOTesting Notes