Add test for writing to undefined identifier and parsing#137
Open
smarr wants to merge 2 commits into
Open
Conversation
Bug report: SOM-st/SOMpp#65 Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
added
the
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two tests based on SOM-st/SOMpp#65
parse_and_methods.som: tests that the parser correctly takes
---as a method name instead of the instance/class separator and that we can print the methods and their holders in two classes. The printing caused a segfault on SOM++ because the holder was not correctly setunknown_field_write2.som: another test for writing to an undefined identifier. SOM++ had a wrong assertion for this case
I don't expect to merge this any time soon, since this requires updating all SOMs. And I should really have a more uniform error format.