Skip to content

add renderSelectedChoices style option#1360

Merged
SBoudrias merged 3 commits intoSBoudrias:masterfrom
matthyk:render-choices-style
Feb 19, 2024
Merged

add renderSelectedChoices style option#1360
SBoudrias merged 3 commits intoSBoudrias:masterfrom
matthyk:render-choices-style

Conversation

@matthyk
Copy link
Copy Markdown
Contributor

@matthyk matthyk commented Feb 17, 2024

Closes #1349 and supersedes #1350

I decided not to pass the current theme to the function. I think the function should really only determine how the selected options should be rendered. Further customisation can already be done with the answer style option.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (44016a4) 94.47% compared to head (0e270fa) 94.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1360   +/-   ##
=======================================
  Coverage   94.47%   94.48%           
=======================================
  Files          53       53           
  Lines        4558     4566    +8     
  Branches      777      778    +1     
=======================================
+ Hits         4306     4314    +8     
  Misses        247      247           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread packages/checkbox/src/index.mts Outdated
@SBoudrias
Copy link
Copy Markdown
Owner

Thanks for following-up! LGTM, just left a nit and we'll be good to merge/release.

matthyk and others added 2 commits February 18, 2024 20:43
Co-authored-by: Simon Boudrias <admin@simonboudrias.com>
@SBoudrias SBoudrias merged commit 4a2a150 into SBoudrias:master Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: transformChoice options for checkbox

2 participants