Skip to content

[Chore] Add regression coverage for incomplete inference setup - #1552

Draft
roomote-roomote[bot] wants to merge 1 commit into
developfrom
fix/onboarding-incomplete-10uk21bdp8m36
Draft

[Chore] Add regression coverage for incomplete inference setup#1552
roomote-roomote[bot] wants to merge 1 commit into
developfrom
fix/onboarding-incomplete-10uk21bdp8m36

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

​Opened on behalf of @mrubens. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

What changed

  • Added server-side coverage for an OpenAI-compatible /v1/models request returning HTTP 400 with no models.
  • Added onboarding coverage proving that this discovery failure shows the provider error without saving model configuration or advancing past inference setup.

Why this change was made

OpenAI-compatible endpoint failures can leave operators repeatedly attempting to continue setup. This coverage pins the intended incomplete state so later setup or provider-validation changes cannot accidentally mark the inference step complete.

Impact

There is no production behavior change. The setup completion contract now has focused regression protection across model discovery and the onboarding interaction.

@roomote-community

roomote-community Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed ff0b50a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant