Skip to content

[Fix] Fast sessions miss merge checkmarks from child PRs - #1517

Merged
daniel-lxs merged 2 commits into
developfrom
fix/fast-session-merge-checkmark-29tyegf09ypzw
Aug 21, 2026
Merged

[Fix] Fast sessions miss merge checkmarks from child PRs#1517
daniel-lxs merged 2 commits into
developfrom
fix/fast-session-merge-checkmark-29tyegf09ypzw

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

​Opened on behalf of @daniel-lxs. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

What changed

Fast Slack sessions now receive the configured completion reaction on the thread root as soon as a delegated child task's pull request merge event is delivered. The reaction is independent of whether Fast posts a closeout or ignores a redundant status event; closed pull requests and unrelated platform events do not receive it.

Why this change was made

Regular Slack task threads already show a completion checkmark when their pull request merges, but Fast sessions did not inherit that terminal signal from child tasks. Tying the reaction to Fast's optional visible reply also allowed redundant merge events to complete without the checkmark.

Impact

Users can see at a glance that a Fast-delegated change has landed without opening the child task or pull request, even when Fast suppresses a redundant merge message. The existing closeout behavior remains unchanged, so this does not add duplicate terminal messages.

@roomote-community

roomote-community Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

  • packages/sdk/src/server/lib/fast-agent-parent-event.ts:351 Merge reactions are skipped when the Fast agent ignores a redundant merge-status event.

Reviewed cf3f0c9

Comment thread packages/sdk/src/server/lib/fast-agent-parent-event.ts Outdated
@roomote-roomote

roomote-roomote Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

Fixed and pushed in cf3f0c9. Merge reactions now run before the Fast agent decides whether to post or ignore the status event, with regression coverage for the ignored-event path.

@daniel-lxs
daniel-lxs marked this pull request as ready for review August 21, 2026 22:14
@daniel-lxs
daniel-lxs merged commit b1b6158 into develop Aug 21, 2026
17 checks passed
@daniel-lxs
daniel-lxs deleted the fix/fast-session-merge-checkmark-29tyegf09ypzw branch August 21, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant