[Fix] Custom Caddy overrides disappear during self-hosted upgrades - #1496
Draft
roomote-community[bot] wants to merge 2 commits into
Draft
[Fix] Custom Caddy overrides disappear during self-hosted upgrades#1496roomote-community[bot] wants to merge 2 commits into
roomote-community[bot] wants to merge 2 commits into
Conversation
Contributor
Author
Contributor
|
All contributors have signed the CLA. |
Contributor
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
/opt/roomote/docker-compose.caddy-dns.ymlafter the managed Compose file for every host CLI operation.Why this change was made
Self-hosted upgrades and pre-upgrade backups previously invoked only
docker-compose.prod.yml. Custom DNS-01 Caddy overrides were therefore dropped during restart, exposing the managed Caddy bind mount and causing upgrades to fail; cleanup then masked that failure with a shell scope error.Impact
Custom Caddy images, certificate configuration, mounts, and other operator Compose overrides remain active during backup, upgrade, restart, and systemd startup. Matching override files remain operator-owned and are not overwritten by upgrades, and systemd continues to use the Docker installation detected during setup.
The focused upgrade, backup restart, and nonstandard Docker path regressions, shell syntax, formatting, lint, type checks, and Knip passed. Deployment validation reached all Compose shape checks, but its Caddy adaptation step could not run because this sandbox exposes no Docker socket.