[Fix] Deleted-line review threads lose anchors and runtime OAuth providers stay connected - #1133
Merged
Merged
Conversation
Contributor
mrubens
marked this pull request as ready for review
August 6, 2026 15:08
mrubens
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
August 6, 2026 15:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
inline.fromand Azure DevOps threads created withleftFileStart.Why this change was made
Review feedback on the v0.35.0 promotion found that deleted-line comments lost their anchors on later reads and that runtime-configured OAuth providers could return before persisted connection cleanup ran.
Impact
Later reviews can match and reply to existing deleted-line threads on Bitbucket and Azure DevOps. Administrators can fully disconnect runtime-configured GitLab, Gitea, and Bitbucket providers, including hook cleanup, OAuth token removal, and repository deactivation.
Focused tests, type checks, formatting, and changed-file lint pass. The full SDK lint remains blocked by two pre-existing unused
eslint-disablewarnings outside this diff.Related PRs