Skip to content

[Fix] Deleted-line review threads lose anchors and runtime OAuth providers stay connected - #1133

Merged
mrubens merged 1 commit into
developfrom
fix/pr-1132-review-feedback
Aug 6, 2026
Merged

[Fix] Deleted-line review threads lose anchors and runtime OAuth providers stay connected#1133
mrubens merged 1 commit into
developfrom
fix/pr-1132-review-feedback

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

Opened on behalf of Matt Rubens. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

What changed

  • Preserve old-side line anchors when reading Bitbucket comments created with inline.from and Azure DevOps threads created with leftFileStart.
  • Treat persisted GitLab, Gitea, and Bitbucket OAuth connections as removable state even when provider client credentials come only from runtime configuration.
  • Add regression coverage and patch changesets for both fixes.

Why this change was made

Review feedback on the v0.35.0 promotion found that deleted-line comments lost their anchors on later reads and that runtime-configured OAuth providers could return before persisted connection cleanup ran.

Impact

Later reviews can match and reply to existing deleted-line threads on Bitbucket and Azure DevOps. Administrators can fully disconnect runtime-configured GitLab, Gitea, and Bitbucket providers, including hook cleanup, OAuth token removal, and repository deactivation.

Focused tests, type checks, formatting, and changed-file lint pass. The full SDK lint remains blocked by two pre-existing unused eslint-disable warnings outside this diff.

Related PRs

@roomote-community

roomote-community Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed 72b9c76

@mrubens
mrubens marked this pull request as ready for review August 6, 2026 15:08
@mrubens
mrubens merged commit 070d763 into develop Aug 6, 2026
18 checks passed
@mrubens
mrubens deleted the fix/pr-1132-review-feedback branch August 6, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant