Refactor core C++ files toward Google C++ style#2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
DTLN_AEC.h, rename the private implementation type toImpland the member toimpl_, and update public API signatures accordingly.DTLN_AEC.cppto use consistent constant names (kWindowSize,kWindowShift,kFftForTensorSize,kNumModels,kNumThreads), apply Google-style spacing and indentation, and bracket third-party includes with// NOLINTBEGIN/// NOLINTEND.AecSample.cppto validateargc, check file opens and initialization failures, return non-zero on error, and replace manualnew[]/delete[]buffers withstd::vector<short>.clang-formatwith the Google style to the modified files to enforce the changes.Testing
clang-format -style=Google -i DTLN_AEC/DTLN_AEC.h DTLN_AEC/DTLN_AEC.cpp AecSample.cppand the command completed successfully.clang-format --dry-run --Werror -style=Google AecSample.cpp DTLN_AEC/DTLN_AEC.cpp DTLN_AEC/DTLN_AEC.hand the check passed.clang-format --dry-run --Werrorreported formatting differences and failed as expected.Codex Task