Vents new terrain 2.0 - #7077
Conversation
|
The lead programmer for Thrive is currently on vacation until 2026-07-13. Until then other programmers will try to make pull request reviews, but please be patient if your PR is not getting reviewed. PRs may be merged after multiple programmers have approved the changes (especially making sure to ensure style guide conformance and gameplay testing are good). If there are no active experienced programmers who can perform merges, PRs may need to wait until the lead programmer is back to be merged. |
|
What's the status on this V2 of this change? |
There was a problem hiding this comment.
I think these changes in this file should be reverted.
There was a problem hiding this comment.
Oh sorry, I missed that!
|
|
||
| entityRecorder.Set(entity, new WorldPosition(location, rotation)); | ||
|
|
||
| entityRecorder.Set<SpatialInstance>(entity); |
There was a problem hiding this comment.
It seems like nothing is ever put in this spatial? So I think it should be excluded from this entity type.
| entityRecorder.Set<StaticBodyMarker>(entity); | ||
| } | ||
|
|
||
| public static void SpawnCollisionWithoutFinalizing(CommandBuffer entityRecorder, |
There was a problem hiding this comment.
| public static void SpawnCollisionWithoutFinalizing(CommandBuffer entityRecorder, | |
| public static void SpawnTerrainCollisionWithoutFinalizing(CommandBuffer entityRecorder, |
Well, it's ready for review - the v2 is from the fact that some month ago I tried to add these vents in a very flawed way and this is the improved version. I will provide the fixes to the issues you pointed when I have time |
| entityRecorder.Set(entity, new PhysicsShapeHolder | ||
| { | ||
| BodyIsStatic = true, | ||
| Shape = shape, |
There was a problem hiding this comment.
Hang on, I just realized something, won't this break on save load? Because PhysicsShape cannot be serialized into a save, so this actually must use a component type that can reload the collision upon loading the save; This shape setting only works in a single play session and is not restored automatically upon loading a save.
Brief Description of What This PR Does
Rework of #6591
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR). This includes gameplay testing by the PR author.
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.