-
Notifications
You must be signed in to change notification settings - Fork 34
feat(navigation-primary): add navigation primary #2171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
192 commits
Select commit
Hold shift + click to select a range
979c78f
fix(blockquote): fix center alignment, enforce blockquote font size a…
adamjohnson 6271efd
Merge branch 'main' into staging/cubone
zeroedin 34b8726
fix(pagination): Colors, right to left demo, and logical properties (…
adamjohnson 1ca07a2
Merge branch 'main' into staging/cubone
adamjohnson 9389123
chore(blockquote): correct changeset level (#2137)
zeroedin 5c16a87
feat(dialog): use native HTML dialog element (#2078)
adamjohnson c247ad7
fix(back-to-top): demo visibility and logical properties (#2133)
adamjohnson e1eaa25
Merge branch 'main' into staging/cubone
bennypowers a8bed6d
feat(navigation-primary): add navigation primary
zeroedin 11f9859
fix(navigation-primary): intrinsic list for nav items, updated slot a…
zeroedin 3f5d4f6
fix(navigation-primary): refactor onExpand
zeroedin a0ccd69
feat(announcement): add `<rh-announcement>` v2 (#2153)
adamjohnson dd899cd
Merge branch 'main' into staging/cubone
bennypowers 2b66b6c
fix(navigation-primary): remove universal design, update to latest st…
zeroedin b1b3fa3
Merge branch 'main' into feat/navigation-primary
zeroedin 296bd9e
fix(avatar): remove grid layout from plain avatar
zeroedin 08aef71
chore: add changeset for avatar change
zeroedin 674f76d
Merge branch 'staging/cubone' into feat/navigation-primary
zeroedin 3d4c41d
fix(navigation-item): correct slots controller
zeroedin 29f897b
fix(navigation-primary): update colors to match design
zeroedin 9dcadbd
fix(navigation-primary): align menu styles add more mock content
zeroedin 7406848
fix(navigation-primary): update caret icons to subtle color
zeroedin d2a8272
fix(navigation-primary): lower breakpoint for links
zeroedin fd972fa
fix(navigation-primary): adjust icon sizes and spacing
zeroedin ba95fcb
docs(navigation-primary): override padding for context demo
zeroedin 5ca8f73
fix(navigation-primary): paddding adjustments
zeroedin 59bddeb
fix(navigation-secondary): add gradient to non standalone items
zeroedin 9271d01
fix(navigation-primary): remove graident from hamburger view
zeroedin 98080cb
fix(navigation-primary): add basic dsd support, style tweaks
zeroedin 27af806
Merge branch 'staging/cubone' into feat/navigation-primary
zeroedin d4d3b01
fix(navigation-primary): inset shadow styles
zeroedin 3bf2d2d
fix(navigation-primary): active state
zeroedin c842f0d
fix(navigation-primary): hover state pills
zeroedin 01aa311
fix(navigation-primary): adjust active focus hover states on pills
zeroedin 9dd3d9d
fix(navigation-primary): adjust pill icon size
zeroedin 2b6b624
fix(navigation-primary): adjust links padding
zeroedin 06e866e
fix(navigation-primary): fix links spacing
zeroedin 1140392
fix(navigation-primary): support links as top level
zeroedin 1474eee
fix(navigation-primary): adjust paadding for top level links
zeroedin b7b518a
feat(overlay): add overlay
zeroedin 5aabf3d
fix(navigation-primary): fix overlay state
zeroedin 1513716
fix(navigation-primary): tweak overlay state
zeroedin 48b5e79
fix(navigation-primary): tweak spacing of quicklinks, fix ios marker
zeroedin 58ce24f
fix(navigation-secondary): overlay closure for secondary dropdowns
zeroedin 6b322f0
fix(navigation-primary): align to design for main dropdowns
zeroedin bcee046
fix(overlay): correct inset
zeroedin d7ce59f
fix(navigation-primary): prep for color context change
zeroedin 4f92b13
docs(navigation-primary): revert removing color-palette from demos th…
zeroedin 65044bc
docs(navigation-primary): add color-palette back to to not-defined
zeroedin bc66480
fix(navigation-primary): size, spacing and positioning tweaks
zeroedin 0e5344a
fix(navigation-primary): rotate hamburger caret with transition
zeroedin 7282920
fix(navigation-primary): more spacing tweaks
zeroedin 3339bef
fix(navigation-primary): improve dehydrated styles
zeroedin 3430ebe
docs(navigation-primary): remove comment
zeroedin 90df736
fix(navigation-primary): revert dehydrate attempt
zeroedin ba1b358
fix(navigation-primary): refactor css take two
zeroedin e0857e2
fix(navigation-primary): overlay state in compact
zeroedin 8c668d7
fix(navigation-primary): fix margin for secondary
zeroedin 5fa3175
fix(navigation-primary): fix non standalone link style
zeroedin cfc8527
fix(navigation-primary): align interactive states with design again
zeroedin 6c5141d
fix(navigation-primary): add fallback values
zeroedin ec7ace2
fix(navigation-primary): add font-family
zeroedin 36ad325
fix(navigation-primary): use height adjustment instead of translation
zeroedin 8c82482
fix(navigation-primary): add onfocusout and keydown tab accessibility…
zeroedin 7880907
fix(navigation-primary): dont close hamburger on escape keypress
zeroedin 80ba309
fix(navigation-primary): visually hide summary
zeroedin 5455ac7
docs(navigation-primary): add title to slotted summit logo
zeroedin ba565ec
fix(navigation-primary): fix title on default svg
zeroedin 7701230
fix(navigation-primary): fix safari render bug
zeroedin b5a9e80
chore(avatar): update changeset
zeroedin b44fbc3
refactor(navigation-primary): bring standalone elements internal to r…
zeroedin b7e1e40
docs(navigation-primary): mock page content
zeroedin 51246ca
Merge branch 'staging/cubone' into feat/navigation-primary
zeroedin 4bd5e0a
fix(navigation-primary): missed class rename in declaration
zeroedin bfb3a63
fix(navigation-primary): clean up
zeroedin 534d4ca
fix(navigation-primary): click should be on summary
zeroedin d4c63d3
fix(navigation-primary): fix shift tab between secondary dropdowns
zeroedin 4570153
fix(navigation-primary): correct spacing for icon and avatar secondary
zeroedin b0e4ee0
fix(navigation-primary): on close overlay
zeroedin 45d5075
docs(navigation-primary): fancier mock data
zeroedin 71c1bb1
fix(navigation-primary): overlay closes only when hamburger not open
zeroedin a5d5606
fix(navigation-primary): in compact and hamburger open
zeroedin e4696e2
docs(navigation-primary): improve readme
zeroedin efcebbc
fix(navigation-primary): safari bug
zeroedin 3059e3f
fix(navigation-primary): remove internal nav element, should have bee…
zeroedin 25b3162
fix(navigation-primary): visually hide not display none hamburger sum…
zeroedin a4016f1
Merge branch 'staging/cubone' into feat/navigation-primary
zeroedin f33bbeb
fix(navigation-primary): update to using light-dark()
zeroedin bff4065
fix(navigation-primary): orphaned on class
zeroedin f89dd68
style(navigation-primary): whitespace
bennypowers 58cba87
style: whitespace
bennypowers c534dd3
style: lint
bennypowers 1c282e9
style: format
bennypowers e415d78
fix(navigation-primary): try forcing update of compact on initial loa…
zeroedin dc455f8
fix(navigation-primary): implement hamburger context, refactor item css
zeroedin 7b29def
docs(navigation-primary): demo text improvement
zeroedin 6b5254a
fix(navigation-primary): handle hamburger menu in tab navigation
zeroedin f0d12ea
fix(navigation-primary): dont close the trigger element on shift+tab …
zeroedin 718a4bb
fix(navigation-primary): remove container part from item
zeroedin f3ba022
style(navigation-primary): format
zeroedin c9ea5d4
refactor: move hamburger css into hamburger
bennypowers 4880165
fix(navigation-primary): css tweaks
zeroedin eccee56
Merge branch 'staging/cubone' into feat/navigation-primary
zeroedin 18ca3cd
refactor(navigation-primary): remove hamburger context, fix dir, docs
zeroedin 0a6cf37
Merge branch 'staging/cubone' into feat/navigation-primary
zeroedin e49358c
fix(navigation-primary): lint
zeroedin abd0a50
fix(navigation-primary): force a compact check after hydration on fir…
zeroedin 1fbd160
fix(navigation-primary): use closest navigtion-primary for offsetWidth
zeroedin d0ff7ac
docs(nav-primary): updating overview page, removing others for now, a…
markcaron 0254934
docs(navigation-primary): fixing relatedItems block
markcaron 7d6fe30
fix(navigation-primary): fix closest usage bug when coming from a sha…
zeroedin 03fc506
docs: lint
zeroedin 16df863
fix(navigation-primary): improve firstupdated compact check
zeroedin 2c93bab
fix(navigation-primary): logical properties all the things
zeroedin 21c0d88
fix(navigation-primary): item should still just check closest as its …
zeroedin d25b05d
docs(navigation-primary): rtl demo
bennypowers b90e7b8
fix(navigation-primary): remove unused rtl class
bennypowers c20afb3
style: formatting
bennypowers d9270ea
perf(navigation-primary): remove custom events
bennypowers 32cd1e8
fix: ok, one custom event :)
bennypowers 7feddcb
fix(navigation-primary): remove colorPalette from item no longer nec…
zeroedin fa693f9
fix(navigation-primary): move mobile toggle label to a property
zeroedin 375c8b6
fix(navigation-primary): readd themeable
zeroedin 7925234
Merge branch 'staging/cubone' into feat/navigation-primary
zeroedin dca61f2
fix(navigation-primary): cleanup on isle 9, missed removing the property
zeroedin 07d7ebd
docs(nav-primary): adding screenshot image
markcaron 7ba37a4
fix(navigation-secondary): use light-dark in svg in case theme tokens…
zeroedin 1ecf143
fix(navigation-primary): correct svg to use fill not class
zeroedin cb7bb08
fix(navigation-primary: scrollbar only on overflow
zeroedin 0724424
fix(navigation-primary: scrollbar only on overflow - item too
zeroedin 87fbd46
docs(nav-primary): cleanup on aisle 6! Wrong directory for screenshots
markcaron daf3bf5
Merge remote-tracking branch 'refs/remotes/origin/feat/navigation-pri…
markcaron fa71802
Merge branch 'staging/cubone' into feat/navigation-primary
zeroedin 5138ca3
docs(navigation-primary): update README code example
zeroedin cfa8f5c
fix(navigation-primary): update class name for overlay to match namin…
zeroedin de78a41
Merge branch 'staging/cubone' into feat/navigation-primary
zeroedin 90259ac
fix(navigation-primary): dont reflect mobile toggle property
zeroedin 206b3a3
Merge branch 'staging/cubone' into feat/navigation-primary
zeroedin a0e84e2
docs(navigation-primary): update demos with api change
zeroedin 20d0672
test(navigation-primary): add tests
zeroedin db51620
chore(navigation-primary): add changeset
zeroedin dd577c6
fix(navigation-primary): remove unused surface
zeroedin 795ef45
Merge branch 'staging/cubone' into feat/navigation-primary
zeroedin 562b872
doc(navigation-primary): cleanup not-defined demo
zeroedin 7fe5498
fix(navigation-primary): fix missing failovers
zeroedin 47154ff
fix(navigation-primary): more missing css failovers
zeroedin 2bfad02
fix(navigation-primary): missing failover in overlay
zeroedin 3854f83
fix(navigation-primary): fixes dropdown event needing target type
zeroedin 52c6126
fix(navigation-primary): appease axe-dev-tools
zeroedin 421d64b
fix(navigation-primary): improved client hydration check of compact
zeroedin ebcb5e9
fix(navigation-primary): improve css
zeroedin 818606a
fix(navigation-primary): remove unused hide class
zeroedin f981a9c
Merge branch 'staging/cubone' into feat/navigation-primary
zeroedin 8205c77
fix(navigation-primary): improve shift+tab handling
zeroedin 71c2c63
fix(navigation-primary): fix css
zeroedin 6c5133d
fix(navigation-primary): another attempt at compact compute, fix not-…
zeroedin b75864e
fix(navigation-primary): adjust height to match mocks
zeroedin 61679a3
fix(navigation-primary): adjust bar padding
zeroedin 81bb510
fix(navigation-primary): adjust logo inline-margin-end
zeroedin a12868d
fix(navigation-primary): fix font-size on standalone links
zeroedin 2c97c26
fix(navigation-primary): hover underline dashed
zeroedin 6c2f610
fix(navigation-primary): correct color of hover underline
zeroedin 8cec6f4
fix(navigation-primary): color correct hover for hamburger items
zeroedin 2c4078e
fix(navigation-primary): fix offset on outline on focus
zeroedin 6e6e233
fix(navigation-primary): adjust divider color
zeroedin 52ac0c2
fix(navigation-primary): show focus ring on active state
zeroedin 21c8af9
fix(navigation-primary): use console instead of developers
zeroedin 6d9a8e1
docs(navigation-primary): missed two demos update to use console
zeroedin c1d621a
chore(navigation-primary): lint
zeroedin b92ec16
fix(navigation-primary): font-size for secondary dropdowns
zeroedin 41aaeb4
fix(navigation-primary): caret icon color, size adjustment
zeroedin 4720e44
fix(icon): microns should allow 8-12px range
zeroedin e0907e5
chore: add icon fix changeset
zeroedin af83f38
fix(navigation-primary): update hamburger caret color and size
zeroedin 9a83101
fix(navigation-primary): adjust border width on active/open
zeroedin f4fc2cf
Merge branch 'staging/cubone' into feat/navigation-primary
zeroedin fdf2e03
docs: revert preamble member on repostatus
bennypowers 491f78b
docs: add preamble to persistent toasted alert
bennypowers 9c1fe8f
fix: roles
bennypowers 303d041
Merge branch 'staging/cubone' into feat/navigation-primary
bennypowers 79f5cc1
doc: internal compact
bennypowers 9044a92
docs(navigation-primary): prepare overview.svg for inlining
bennypowers 97f1ecd
fix: don't instanciate with role
bennypowers 6740ffd
Merge branch 'staging/cubone' into feat/navigation-primary
zeroedin 2041cff
fix: appease axe core when lit ssr is around
bennypowers 2a67deb
fix(navigation-primary): top level links text-decoration underline
zeroedin 63d5dab
fix(navigation-primary): remove border radius from hamburger details …
zeroedin 261790e
fix(navigation-primary): remove border-radius from full width dropdowns
zeroedin 0ec08d2
fix(navigation-primary): fix focus state no gradient border
zeroedin c7892cf
fix(navigation-primary): remove border radius for items when full width
zeroedin 83c0fc6
Merge branch 'staging/cubone' into feat/navigation-primary
zeroedin 92c3ede
docs: update not-defined.html
bennypowers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@rhds/elements": patch | ||
| --- | ||
|
|
||
| `<rh-icon>`: corrected micron set to allow for a range from 8px to 12px |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@rhds/elements": patch | ||
| --- | ||
|
|
||
| `<rh-avatar>`: improved layout compatibility for plain variant avatars |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| --- | ||
| "@rhds/elements": minor | ||
| --- | ||
|
|
||
| ✨ Added `<rh-navigation-primary>`. | ||
|
|
||
| The Primary navigation allows users to orient themselves and successfully move through web experiences. It is | ||
| persistent on every page to ensure a consistent user experience across our systems of website | ||
|
|
||
| ```html | ||
| <rh-navigation-primary> | ||
| <rh-navigation-primary-item variant="dropdown" summary="AI"> | ||
| AI dropdown content | ||
| </rh-navigation-primary-item> | ||
|
|
||
| <rh-navigation-primary-item variant="dropdown" summary="Hybrid Cloud"> | ||
| Hybrid Cloud dropdown content | ||
| </rh-navigation-primary-item> | ||
|
|
||
| <rh-navigation-primary-item variant="dropdown" summary="Products"> | ||
| Products dropdown content | ||
| </rh-navigation-primary-item> | ||
|
|
||
| <rh-navigation-primary-item variant="dropdown" summary="Learn"> | ||
| Learn dropdown content | ||
| </rh-navigation-primary-item> | ||
|
|
||
| <rh-navigation-primary-item variant="dropdown" summary="Partners"> | ||
| Partners dropdown content | ||
| </rh-navigation-primary-item> | ||
|
|
||
| <rh-navigation-primary-item slot="links"> | ||
| <a href="https://developers.redhat.com/">Developers</a> | ||
| </rh-navigation-primary-item> | ||
|
|
||
| <rh-navigation-primary-item slot="links"> | ||
| <a href="https://docs.redhat.com/en">Docs</a> | ||
| </rh-navigation-primary-item> | ||
|
|
||
| <rh-navigation-primary-item slot="links"> | ||
| <a href="https://access.redhat.com/support">Support</a> | ||
| </rh-navigation-primary-item> | ||
|
|
||
| <rh-navigation-primary-item slot="dropdowns" variant="dropdown" hide="sm" summary="Search"> | ||
| Search dropdown content | ||
| </rh-navigation-primary-item> | ||
|
|
||
| <rh-navigation-primary-item slot="dropdowns" variant="dropdown" hide="sm" summary="For you"> | ||
| For you dropdown content | ||
| </rh-navigation-primary-item> | ||
|
|
||
| <rh-navigation-primary-item slot="dropdowns" variant="dropdown" summary="My Red Hat"> | ||
| My Red Hat dropdown content | ||
| </rh-navigation-primary-item> | ||
| </rh-navigation-primary> | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -67,6 +67,7 @@ rules: | |
| - true | ||
| - allowed: | ||
| - --rh-icon-size | ||
| - --rh-navigation-active-item-color | ||
|
|
||
| overrides: | ||
| - files: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,5 +20,7 @@ svg { | |
| } | ||
|
|
||
| .microns svg { | ||
| width: 12px; | ||
| min-width: 8px; | ||
| max-width: 12px; | ||
| width: var(--rh-icon-size, 12px); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| # Navigation Primary | ||
|
|
||
| Primary navigation for top level site navigation. | ||
|
|
||
| ## Usage | ||
|
|
||
|
|
||
| ```html | ||
| <rh-navigation-primary> | ||
| <rh-navigation-primary-item variant="dropdown"> | ||
| <span slot="summary">Item 1</span> | ||
| Item 1 Content | ||
| </rh-navigation-primary-item> | ||
|
|
||
| <rh-navigation-primary-item variant="dropdown"> | ||
| <span slot="summary">Item 2</span> | ||
| Item 2 Content | ||
| </rh-navigation-primary-item> | ||
|
|
||
| <rh-navigation-primary-item variant="dropdown"> | ||
| <span slot="summary">Item 3</span> | ||
| Item 3 Content | ||
| </rh-navigation-primary-item> | ||
|
|
||
| <rh-navigation-primary-item variant="dropdown"> | ||
| <span slot="summary">Item 4</span> | ||
| Item 4 Content | ||
| </rh-navigation-primary-item> | ||
|
|
||
| <rh-navigation-primary-item variant="dropdown"> | ||
| <span slot="summary">Item 5</span> | ||
| Item 5 Content | ||
| </rh-navigation-primary-item> | ||
|
|
||
| <rh-navigation-primary-item slot="links">Link 1</rh-navigation-primary-item> | ||
| <rh-navigation-primary-item slot="links">Link 2</rh-navigation-primary-item> | ||
| <rh-navigation-primary-item slot="links">Link 3</rh-navigation-primary-item> | ||
|
|
||
| <rh-navigation-primary-item slot="dropdowns" variant="dropdown"> | ||
| <span slot="summary">Item 6</span> | ||
| Item 6 Content | ||
| </rh-navigation-primary-item> | ||
|
|
||
| <rh-navigation-primary-item slot="dropdowns" variant="dropdown"> | ||
| <span slot="summary">Item 7</span> | ||
| Item 7 Content | ||
| </rh-navigation-primary-item> | ||
|
|
||
| <rh-navigation-primary-item slot="dropdowns" variant="dropdown"> | ||
| <span slot="summary">Item 8</span> | ||
| Item 8 Content | ||
| </rh-navigation-primary-item> | ||
| </rh-navigation-primary> | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import { createContextWithRoot } from '@patternfly/pfe-core/functions/context.js'; | ||
|
|
||
| export const context = createContextWithRoot<boolean>( | ||
| Symbol('rh-navigation-primary-item-compact-context'), | ||
| ); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.