Skip to content
This repository was archived by the owner on May 25, 2023. It is now read-only.

Noreg order#5

Open
Gomez wants to merge 29 commits into
Raptus:masterfrom
Gomez:noreg_order
Open

Noreg order#5
Gomez wants to merge 29 commits into
Raptus:masterfrom
Gomez:noreg_order

Conversation

@Gomez

@Gomez Gomez commented Aug 8, 2014

Copy link
Copy Markdown
Contributor

try to get anonymous order switch into master

@Gomez

Gomez commented Aug 8, 2014

Copy link
Copy Markdown
Contributor Author

rebased. Good to merge?

@Gomez

Gomez commented Aug 27, 2014

Copy link
Copy Markdown
Contributor Author

@skaeser Is this of interest?

@skaeser

skaeser commented Oct 16, 2014

Copy link
Copy Markdown
Member

Hey @Gomez this is of interest yes, thanks.. ;-)

I quickly scanned through the changes and found some issues, which would need to be resolved in order to get merged:

https://github.com/Gomez/pcommerce.core/blob/noreg_order/src/pcommerce/core/profiles/default/.propertiestool.xml.swp should be removed

https://github.com/Gomez/pcommerce.core/blob/noreg_order/src/pcommerce/core/browser/getprice.js and https://github.com/Gomez/pcommerce.core/blob/noreg_order/src/pcommerce/core/browser/javascripts/as_customer.js should be properly wrapped as mentioned above, e.g.

(function($) {
  $('document').ready(function() {
  // [...]
})(jQuery);

https://github.com/Gomez/pcommerce.core/blob/noreg_order/src/pcommerce/core/browser/javascripts/as_customer.js seems to have left merging info, which needs to be removed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants