Skip to content

fix(rpp): Remove Ofast compiling option from CMakeList.txt and change uchar type#9237

Merged
rrawther merged 3 commits into
developfrom
users/rrawther/rpp-cmake-warning-fix
Jul 10, 2026
Merged

fix(rpp): Remove Ofast compiling option from CMakeList.txt and change uchar type#9237
rrawther merged 3 commits into
developfrom
users/rrawther/rpp-cmake-warning-fix

Conversation

@rrawther

@rrawther rrawther commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Motivation

This PR addresses compile warnings with Ofast flag. Instead changed to use -fast-math

Technical Details

Modified compile flags to use standard O3
Removed the use of uchar data-type from RPP test-suite which is only defined in OpenCV

Test Plan

CTests should pass

Test Result

  Start  1: rpp_sanity_test_brightness_host_f32

1/10 Test #1: rpp_sanity_test_brightness_host_f32 ......... Passed 3.64 sec
Start 2: rpp_sanity_test_brightness_hip_f32
2/10 Test #2: rpp_sanity_test_brightness_hip_f32 .......... Passed 7.75 sec
Start 3: rpp_qa_tests_tensor_image_host_all
3/10 Test #3: rpp_qa_tests_tensor_image_host_all .......... Passed 42.43 sec
Start 4: rpp_qa_tests_tensor_voxel_host_all
4/10 Test #4: rpp_qa_tests_tensor_voxel_host_all .......... Passed 2.26 sec
Start 5: rpp_qa_tests_tensor_misc_host_all
5/10 Test #5: rpp_qa_tests_tensor_misc_host_all ........... Passed 7.74 sec
Start 6: rpp_qa_tests_tensor_misc_host_test_type_1
6/10 Test #6: rpp_qa_tests_tensor_misc_host_test_type_1 ... Passed 402.60 sec
Start 7: rpp_qa_tests_tensor_image_hip_all
7/10 Test #7: rpp_qa_tests_tensor_image_hip_all ........... Passed 84.44 sec
Start 8: rpp_qa_tests_tensor_voxel_hip_all
8/10 Test #8: rpp_qa_tests_tensor_voxel_hip_all ........... Passed 4.62 sec
Start 9: rpp_qa_tests_tensor_misc_hip_all
9/10 Test #9: rpp_qa_tests_tensor_misc_hip_all ............ Passed 16.50 sec
Start 10: rpp_qa_tests_tensor_misc_hip_test_type_1
10/10 Test #10: rpp_qa_tests_tensor_misc_hip_test_type_1 .... Passed 348.19 sec

100% tests passed, 0 tests failed out of 10

Submission Checklist

@rrawther rrawther requested a review from a team as a code owner July 9, 2026 18:54
@rrawther rrawther requested a review from kiritigowda July 9, 2026 18:55
@rrawther rrawther requested a review from LakshmiKumar23 July 9, 2026 18:55
@therock-pr-bot

therock-pr-bot Bot commented Jul 9, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ❌ Fail Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/rpp/utilities/test_suite/HIP/Tensor_voxel_hip.cpp, projects/rpp/utilities/test_suite/HOST/Tensor_voxel_host.cpp, projects/rpp/utilities/test_suite/rpp_test_suite_voxel.h; no test file found
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ Unit Test

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

therock-pr-bot Bot commented Jul 9, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ Unit Test

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@rrawther rrawther merged commit 9272c48 into develop Jul 10, 2026
15 of 16 checks passed
@rrawther rrawther deleted the users/rrawther/rpp-cmake-warning-fix branch July 10, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants