fix(rpp): Remove Ofast compiling option from CMakeList.txt and change uchar type#9237
Merged
Merged
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
kiritigowda
approved these changes
Jul 9, 2026
LakshmiKumar23
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR addresses compile warnings with Ofast flag. Instead changed to use -fast-math
Technical Details
Modified compile flags to use standard O3
Removed the use of uchar data-type from RPP test-suite which is only defined in OpenCV
Test Plan
CTests should pass
Test Result
1/10 Test #1: rpp_sanity_test_brightness_host_f32 ......... Passed 3.64 sec
Start 2: rpp_sanity_test_brightness_hip_f32
2/10 Test #2: rpp_sanity_test_brightness_hip_f32 .......... Passed 7.75 sec
Start 3: rpp_qa_tests_tensor_image_host_all
3/10 Test #3: rpp_qa_tests_tensor_image_host_all .......... Passed 42.43 sec
Start 4: rpp_qa_tests_tensor_voxel_host_all
4/10 Test #4: rpp_qa_tests_tensor_voxel_host_all .......... Passed 2.26 sec
Start 5: rpp_qa_tests_tensor_misc_host_all
5/10 Test #5: rpp_qa_tests_tensor_misc_host_all ........... Passed 7.74 sec
Start 6: rpp_qa_tests_tensor_misc_host_test_type_1
6/10 Test #6: rpp_qa_tests_tensor_misc_host_test_type_1 ... Passed 402.60 sec
Start 7: rpp_qa_tests_tensor_image_hip_all
7/10 Test #7: rpp_qa_tests_tensor_image_hip_all ........... Passed 84.44 sec
Start 8: rpp_qa_tests_tensor_voxel_hip_all
8/10 Test #8: rpp_qa_tests_tensor_voxel_hip_all ........... Passed 4.62 sec
Start 9: rpp_qa_tests_tensor_misc_hip_all
9/10 Test #9: rpp_qa_tests_tensor_misc_hip_all ............ Passed 16.50 sec
Start 10: rpp_qa_tests_tensor_misc_hip_test_type_1
10/10 Test #10: rpp_qa_tests_tensor_misc_hip_test_type_1 .... Passed 348.19 sec
100% tests passed, 0 tests failed out of 10
Submission Checklist