[CI] Parity: support sha=latest by resolving the latest green run on main#3393
Open
ethanwee1 wants to merge 1 commit into
Open
[CI] Parity: support sha=latest by resolving the latest green run on main#3393ethanwee1 wants to merge 1 commit into
ethanwee1 wants to merge 1 commit into
Conversation
…main download_testlogs required exactly one of --pr_id or --sha1 and rejected the "neither" case, so dispatching parity with an empty/"latest" sha (the documented "latest green on main" option, e.g. a baseline_sha comparison) failed with "Please provide either pr_id or sha!". Treat an empty --sha1 or the literal "latest" as "resolve latest green run on main": look up the newest successful ROCm default-workflow run on main (download_workflow_run already does this when given no head_sha) and use its head commit as the target sha. The parity.yml side already omits --sha1 for "latest", so no workflow change is needed. Also clarifies the both-provided error message.
|
Jenkins build for 3ec517c634d490e4e861552aa79118d6f12b06ea commit finished as FAILURE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dispatching a parity run with the
shainput left empty / set tolatest— the documented "latest green on main" option (e.g. thebaseline_shacommit-vs-commit comparison in this failing run) — failed immediately with:download_testlogsrequired exactly one of--pr_idor--sha1and rejected the "neither" case, solatestwas never actually supported despite the input hint saying "Leave empty for latest green on main."Fix
Treat an empty
--sha1(or the literal stringlatest) as "resolve the latest green run on main":mainand use its head commit as the targetsha.download_workflow_run()already does exactly this when called with nohead_sha, so the change is small and self-contained.parity.ymlside already omits--sha1when the input islatest, so no workflow change is needed.pr_idand a realsha).Kept entirely in
download_testlogsso the script still works standalone (./download_testlogs --arch mi300now resolves latest instead of erroring).Validation (on fork)
baseline_sha+ empty sha, mi200): run 28811245419 — the guard no longer errors; the log now showsNo sha or pr_id given; resolving latest green ROCm run on main... Resolved 'latest' to sha: a09b29e7.... (That run then stops later only because the arbitrary baseline commit's mi200 artifacts have expired —HTTP 410 Gone— which is unrelated to this change.)latestrun (no baseline, mi300): run 28811384934 — end-to-end latest-green resolution + parity.Test plan
sha=latest/ empty no longer errors at the download step; resolves to a concrete head SHA.pr_idpath unchanged.latestrun produces a summary.