Skip to content

build: Delete therock-boost now that it is no longer used#6311

Open
ScottTodd wants to merge 1 commit into
mainfrom
users/scotttodd/boost-delete
Open

build: Delete therock-boost now that it is no longer used#6311
ScottTodd wants to merge 1 commit into
mainfrom
users/scotttodd/boost-delete

Conversation

@ScottTodd

@ScottTodd ScottTodd commented Jul 1, 2026

Copy link
Copy Markdown
Member

Motivation

Fixes #5146

New dependencies on boost (https://www.boost.org/) have been banned for a while and existing dependencies have all been removed with:

project removal commit date committed
rocRoller ROCm/rocm-libraries@61a4cb9 2025-09-26
rocFFT/hipFFT ROCm/rocm-libraries@8e8d667 2026-01-07
hip-tests ROCm/rocm-systems@a681e4d 2026-02-26
hipFile ROCm/rocm-systems@4fe3c3d 2026-05-05

Test Plan

Local build on Windows + CI run (https://github.com/ROCm/TheRock/actions/runs/28539662223?pr=6311) both succeeded.

Submission Checklist

@therock-pr-bot

therock-pr-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

therock-pr-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@ScottTodd ScottTodd changed the title Delete therock-boost now that it is no longer used build: Delete therock-boost now that it is no longer used Jul 1, 2026
@ScottTodd ScottTodd marked this pull request as ready for review July 1, 2026 21:02

@marbre marbre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

[Issue]: [Windows][Build] Boost build failure with latest Visual Studio Build Tools (2026)

2 participants