fix(ci): Use dedicated directory for patched patchelf sources#6286
fix(ci): Use dedicated directory for patched patchelf sources#6286robotchaoX wants to merge 1 commit into
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
There was a problem hiding this comment.
Pull request overview
Updates the patchelf install helper used by the manylinux Docker build so that patched patchelf sources are extracted and built from a dedicated patchelf/ directory instead of a generic src/, reducing confusion and workspace clutter when run manually.
Changes:
- Extract
patchelf.tar.gzintopatchelf/instead ofsrc/. - Run the patchelf build from within
patchelf/. - Add a
.gitignorerule to ignore generated top-level patchelf artifacts.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| dockerfiles/install_patchelf.sh | Uses a dedicated patchelf/ extraction/build directory instead of src/. |
| .gitignore | Ignores generated patchelf artifacts at the repository root. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
92d6119 to
1beaa52
Compare
Avoid extracting patched patchelf sources into a generic top-level src/ directory. That name is easy to confuse with project source trees when the helper is run manually or from different working directories. Extract into a top-level patchelf/ directory instead and ignore the generated patchelf artifacts so local install runs do not leave noisy untracked files.
1beaa52 to
abdf052
Compare
Summary
This updates
install_patchelf.shto extract patched patchelf sources into a dedicated top-levelpatchelf/directory instead of the genericsrc/directory.Using
src/is easy to confuse with project source trees when the helper is run manually or from different working directories. A dedicatedpatchelf/directory makes the generated checkout self-describing and reduces local workspace noise.The generated patchelf artifacts are also ignored in
.gitignore.Changes
patchelf.tar.gzintopatchelf/instead ofsrc/.patchelf/.