Skip to content

fix(ci): Use dedicated directory for patched patchelf sources#6286

Open
robotchaoX wants to merge 1 commit into
ROCm:mainfrom
robotchaoX:users/jinchaxu/dedicated-patchelf-directory
Open

fix(ci): Use dedicated directory for patched patchelf sources#6286
robotchaoX wants to merge 1 commit into
ROCm:mainfrom
robotchaoX:users/jinchaxu/dedicated-patchelf-directory

Conversation

@robotchaoX

Copy link
Copy Markdown

Summary

This updates install_patchelf.sh to extract patched patchelf sources into a dedicated top-level patchelf/ directory instead of the generic src/ directory.

Using src/ is easy to confuse with project source trees when the helper is run manually or from different working directories. A dedicated patchelf/ directory makes the generated checkout self-describing and reduces local workspace noise.

The generated patchelf artifacts are also ignored in .gitignore.

Changes

  • Extract patchelf.tar.gz into patchelf/ instead of src/.
  • Run the patchelf build from patchelf/.
  • Ignore generated top-level patchelf artifacts.

@therock-pr-bot

therock-pr-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
JIRA ID : TESTAUTO-6039
JIRA ID - #330
JIRA ID #330
ISSUE ID : TESTUTO-3334
ISSUE ID #3334
ISSUE ID - TESTAUTO-3433
ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
Closes #10
Fixes octo-org/octo-repo#100
Resolves: #123
#123
https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Title/Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Jul 1, 2026
@therock-pr-bot

therock-pr-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Title/Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the patchelf install helper used by the manylinux Docker build so that patched patchelf sources are extracted and built from a dedicated patchelf/ directory instead of a generic src/, reducing confusion and workspace clutter when run manually.

Changes:

  • Extract patchelf.tar.gz into patchelf/ instead of src/.
  • Run the patchelf build from within patchelf/.
  • Add a .gitignore rule to ignore generated top-level patchelf artifacts.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
dockerfiles/install_patchelf.sh Uses a dedicated patchelf/ extraction/build directory instead of src/.
.gitignore Ignores generated patchelf artifacts at the repository root.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread dockerfiles/install_patchelf.sh
@robotchaoX robotchaoX force-pushed the users/jinchaxu/dedicated-patchelf-directory branch from 92d6119 to 1beaa52 Compare July 1, 2026 07:08
Avoid extracting patched patchelf sources into a generic top-level src/ directory. That name is easy to confuse with project source trees when the helper is run manually or from different working directories.

Extract into a top-level patchelf/ directory instead and ignore the generated patchelf artifacts so local install runs do not leave noisy untracked files.
@robotchaoX robotchaoX force-pushed the users/jinchaxu/dedicated-patchelf-directory branch from 1beaa52 to abdf052 Compare July 3, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Not ready to Review PR has unresolved policy failures — reviews blocked

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

2 participants